Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix hive text reader can't recognize last empty element #52990

Merged
merged 1 commit into from
Nov 19, 2024
Merged

[BugFix] Fix hive text reader can't recognize last empty element #52990

merged 1 commit into from
Nov 19, 2024

Conversation

Smith-Cruise
Copy link
Contributor

@Smith-Cruise Smith-Cruise commented Nov 19, 2024 •
edited
Loading

Why I'm doing:

User's data is ["1", "2", ""]
We will read as ["1", "2"]

What I'm doing:

fix it

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@Smith-Cruise
Fix text reader can't recognize last empty element
257fa23 
Signed-off-by: Smith Cruise <chendingchao1@126.com>
@Smith-Cruise Smith-Cruise requested a review from a team as a code owner November 19, 2024 07:21
@Smith-Cruise Smith-Cruise changed the title [BugFix] Fix text reader can't recognize last empty element [BugFix] Fix hive text reader can't recognize last empty element Nov 19, 2024
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/formats/csv/array_reader.cpp 1 1 100.00% []

@wyb wyb merged commit 14d6654 into StarRocks:main Nov 19, 2024
52 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Nov 19, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Nov 19, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Nov 19, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 19, 2024
@Smith-Cruise @mergify
[BugFix] Fix hive text reader can't recognize last empty element (#52990
88af13e 
)

Signed-off-by: Smith Cruise <chendingchao1@126.com>
(cherry picked from commit 14d6654)
@mergify mergify bot mentioned this pull request Nov 19, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Nov 19, 2024
@Smith-Cruise @mergify
[BugFix] Fix hive text reader can't recognize last empty element (#52990
2213a7a 
)

Signed-off-by: Smith Cruise <chendingchao1@126.com>
(cherry picked from commit 14d6654)
@mergify mergify bot mentioned this pull request Nov 19, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Nov 19, 2024
@Smith-Cruise @mergify
[BugFix] Fix hive text reader can't recognize last empty element (#52990
fc1dc11 
)

Signed-off-by: Smith Cruise <chendingchao1@126.com>
(cherry picked from commit 14d6654)
@mergify mergify bot mentioned this pull request Nov 19, 2024
Open
42 tasks
mergify bot pushed a commit that referenced this pull request Nov 19, 2024
@Smith-Cruise @mergify
[BugFix] Fix hive text reader can't recognize last empty element (#52990
470b305 
)

Signed-off-by: Smith Cruise <chendingchao1@126.com>
(cherry picked from commit 14d6654)
@mergify mergify bot mentioned this pull request Nov 19, 2024
Open
42 tasks
mergify bot pushed a commit that referenced this pull request Nov 19, 2024
@Smith-Cruise @mergify
[BugFix] Fix hive text reader can't recognize last empty element (#52990
6463a8b 
)

Signed-off-by: Smith Cruise <chendingchao1@126.com>
(cherry picked from commit 14d6654)

# Conflicts:
#	be/src/formats/csv/array_reader.cpp
#	be/test/exec/vectorized/hdfs_scanner_test.cpp
@mergify mergify bot mentioned this pull request Nov 19, 2024
Closed
42 tasks
@Smith-Cruise Smith-Cruise deleted the fix-text-array-last-element branch November 19, 2024 11:03
wanpengfei-git pushed a commit that referenced this pull request Nov 19, 2024
@mergify @Smith-Cruise
[BugFix] Fix hive text reader can't recognize last empty element (bac…
6e15118 
…kport #52990) (#53002)

Co-authored-by: Smith Cruise <chendingchao1@126.com>
wanpengfei-git pushed a commit that referenced this pull request Nov 19, 2024
@mergify @Smith-Cruise
[BugFix] Fix hive text reader can't recognize last empty element (bac…
604a778 
…kport #52990) (#53001)

Co-authored-by: Smith Cruise <chendingchao1@126.com>
Smith-Cruise added a commit to Smith-Cruise/starrocks that referenced this pull request Nov 26, 2024
@Smith-Cruise
[BugFix] Fix hive text reader can't recognize last empty element (Sta…
c749eb6 
…rRocks#52990)

Signed-off-by: Smith Cruise <chendingchao1@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirtysalt dirtysalt dirtysalt approved these changes

@wyb wyb wyb approved these changes

Assignees

@Smith-Cruise Smith-Cruise

Labels
3.2-merged 3.2 3.3-merged 3.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Smith-Cruise @wyb @dirtysalt