Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Reduce lock time of schema change in scenarios with a large number of columns #52800

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

trueeyu
Copy link
Contributor

@trueeyu trueeyu commented Nov 11, 2024

Why I'm doing:

This check compatible has a complexity of N^2. In a scenario with many columns (>10000), it will be very slow, causing the table lock to be held for a long time and the import will be stuck.

What I'm doing:

Using hash map to replace the link list.

For a table with 20,000 columns, the lock holding time can be optimized from 12s to 0.8s.

TODO: 0.8s is not reasonable. There is still some optimization points and continuous optimization is needed.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

… columns

Signed-off-by: trueeyu <lxhhust350@qq.com>
@trueeyu trueeyu force-pushed the schema_change_opt_2 branch from 10fa3d2 to 7569df1 Compare November 12, 2024 02:24
@trueeyu trueeyu changed the title [OnlyForTest] Schema change opt 2 [Enhancement] Reduce lock time of schema change in scenarios with a large number of columns Nov 12, 2024
@trueeyu trueeyu marked this pull request as ready for review November 12, 2024 02:55
@trueeyu trueeyu requested a review from a team as a code owner November 12, 2024 02:55
Copy link

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 22 / 22 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/alter/SchemaChangeHandler.java 22 22 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@wyb wyb merged commit f004276 into StarRocks:main Nov 12, 2024
68 of 72 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Nov 12, 2024
Copy link

@Mergifyio backport branch-3.2

Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.2 label Nov 12, 2024
Copy link
Contributor

mergify bot commented Nov 12, 2024

backport branch-3.3

✅ Backports have been created

@github-actions github-actions bot removed the 3.1 label Nov 12, 2024
Copy link
Contributor

mergify bot commented Nov 12, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Nov 12, 2024

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 12, 2024
…arge number of columns (#52800)

Signed-off-by: trueeyu <lxhhust350@qq.com>
(cherry picked from commit f004276)
mergify bot pushed a commit that referenced this pull request Nov 12, 2024
…arge number of columns (#52800)

Signed-off-by: trueeyu <lxhhust350@qq.com>
(cherry picked from commit f004276)
mergify bot pushed a commit that referenced this pull request Nov 12, 2024
…arge number of columns (#52800)

Signed-off-by: trueeyu <lxhhust350@qq.com>
(cherry picked from commit f004276)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/alter/SchemaChangeHandler.java
#	fe/fe-core/src/test/java/com/starrocks/alter/SchemaChangeHandlerTest.java
wanpengfei-git pushed a commit that referenced this pull request Nov 13, 2024
…arge number of columns (backport #52800) (#52842)

Co-authored-by: trueeyu <lxhhust350@qq.com>
wanpengfei-git pushed a commit that referenced this pull request Nov 13, 2024
…arge number of columns (backport #52800) (#52843)

Co-authored-by: trueeyu <lxhhust350@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants