Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] only create IO Entry when enable IOProfiler #52756

Merged
merged 2 commits into from
Nov 12, 2024
Merged

[BugFix] only create IO Entry when enable IOProfiler #52756

merged 2 commits into from
Nov 12, 2024

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Nov 8, 2024

Why I'm doing:

two issue:

  1. we don't have to create entry when disable io profiler
  2. fix maybe use-after-free when enable io profiler

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@stdpain stdpain requested a review from a team as a code owner November 8, 2024 12:56
@mergify mergify bot assigned stdpain Nov 8, 2024
@stdpain
[BugFix] only create IO Entry when enable IOProfiler
caffd31 
Signed-off-by: stdpain <drfeng08@gmail.com>
@stdpain stdpain force-pushed the only_create_io_entry_when_enable_io_profiler branch from 2f9d236 to caffd31 Compare November 8, 2024 13:03
kangkaisen
kangkaisen previously approved these changes Nov 8, 2024
View reviewed changes
decster
decster previously approved these changes Nov 8, 2024
View reviewed changes
alvin-celerdata
alvin-celerdata previously approved these changes Nov 8, 2024
View reviewed changes
@stdpain
fix UT
3a7d4ae 
Signed-off-by: stdpain <drfeng08@gmail.com>
@stdpain stdpain dismissed stale reviews from alvin-celerdata, decster, and kangkaisen via 3a7d4ae November 11, 2024 07:25
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 6 / 6 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/io/io_profiler.cpp 6 6 100.00% []

@kangkaisen kangkaisen merged commit 1274fa5 into StarRocks:main Nov 12, 2024
47 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Nov 12, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Nov 12, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 12, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 12, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 12, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 12, 2024 •
edited
Loading

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 12, 2024
@stdpain @mergify
[BugFix] only create IO Entry when enable IOProfiler (#52756)
76b7474 
Signed-off-by: stdpain <drfeng08@gmail.com>
(cherry picked from commit 1274fa5)
mergify bot pushed a commit that referenced this pull request Nov 12, 2024
@stdpain @mergify
[BugFix] only create IO Entry when enable IOProfiler (#52756)
98b9410 
Signed-off-by: stdpain <drfeng08@gmail.com>
(cherry picked from commit 1274fa5)

# Conflicts:
#	be/test/io/io_profiler_test.cpp
mergify bot pushed a commit that referenced this pull request Nov 12, 2024
@stdpain @mergify
[BugFix] only create IO Entry when enable IOProfiler (#52756)
402c511 
Signed-off-by: stdpain <drfeng08@gmail.com>
(cherry picked from commit 1274fa5)

# Conflicts:
#	be/test/io/io_profiler_test.cpp
This was referenced Nov 12, 2024
Merged
Merged
Merged
mergify bot pushed a commit that referenced this pull request Nov 12, 2024
@stdpain @mergify
[BugFix] only create IO Entry when enable IOProfiler (#52756)
cca7dfd 
Signed-off-by: stdpain <drfeng08@gmail.com>
(cherry picked from commit 1274fa5)

# Conflicts:
#	be/test/io/io_profiler_test.cpp
@mergify mergify bot mentioned this pull request Nov 12, 2024
Open
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Nov 12, 2024
@mergify @stdpain
[BugFix] only create IO Entry when enable IOProfiler (backport #52756) (
2070e49 
#52822)

Signed-off-by: stdpain <34912776+stdpain@users.noreply.github.com>
Co-authored-by: stdpain <34912776+stdpain@users.noreply.github.com>
wanpengfei-git pushed a commit that referenced this pull request Nov 12, 2024
@mergify @stdpain
[BugFix] only create IO Entry when enable IOProfiler (backport #52756) (
d3d74f3 
#52821)

Signed-off-by: stdpain <34912776+stdpain@users.noreply.github.com>
Co-authored-by: stdpain <34912776+stdpain@users.noreply.github.com>
wanpengfei-git pushed a commit that referenced this pull request Nov 12, 2024
@mergify @stdpain
[BugFix] only create IO Entry when enable IOProfiler (backport #52756) (
ebacbda 
#52820)

Co-authored-by: stdpain <34912776+stdpain@users.noreply.github.com>
@stdpain stdpain deleted the only_create_io_entry_when_enable_io_profiler branch December 4, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decster decster decster approved these changes

@kangkaisen kangkaisen kangkaisen approved these changes

@alvin-celerdata alvin-celerdata alvin-celerdata approved these changes

Assignees

@stdpain stdpain

Labels
3.1-merged 3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stdpain @decster @kangkaisen @alvin-celerdata