Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix Expr::open crash when evaluate const throw exception #52752

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Nov 8, 2024

Why I'm doing:

*** SIGABRT (@0x3eb00138aa5) received by PID 1280677 (TID 0x7f1e2cdfd640) from PID 1280677; stack trace: ***
    @     0x7f1f29989ee8 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x99ee7)
    @          0x8e6d929 google::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*)
    @     0x7f1f29932520 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x4251f)
    @     0x7f1f299869fc pthread_kill
    @     0x7f1f29932476 raise
    @     0x7f1f299187f3 abort
    @          0xc5f6023 __gnu_cxx::__verbose_terminate_handler() [clone .cold]
    @          0xc5f45fc __cxxabiv1::__terminate(void (*)())
    @          0xc5f4667 std::terminate()
    @          0xc5f47c9 __cxa_throw
    @          0x66ef486 starrocks::DecimalNonDecimalCast<(starrocks::OverflowMode)2, (starrocks::LogicalType)48, (starrocks::LogicalType)9, int, int>::decimal_from(std::shared_ptr<starrocks::Column> const&, int, int)
    @          0x66ef5f0 std::shared_ptr<starrocks::Column> starrocks::UnpackConstColumnUnaryFunction<starrocks::DecimalFrom<(starrocks::OverflowMode)2> >::evaluate<(starrocks::LogicalType)9, (starrocks::LogicalType)48, int const&, int const&>(std::shared_ptr<starrocks::Column> co5^A
    @          0x66ef7b1 std::shared_ptr<starrocks::Column> starrocks::DealNullableColumnUnaryFunction<starrocks::UnpackConstColumnUnaryFunction<starrocks::DecimalFrom<(starrocks::OverflowMode)2> > >::evaluate<(starrocks::LogicalType)9, (starrocks::LogicalType)48, int const&, int 5^A
    @          0x66f049c starrocks::VectorizedCastExpr<(starrocks::LogicalType)9, (starrocks::LogicalType)48, false>::evaluate_checked(starrocks::ExprContext*, starrocks::Chunk*)
    @          0x6834aa4 starrocks::VectorizedInConstPredicate<(starrocks::LogicalType)48>::open(starrocks::RuntimeState*, starrocks::ExprContext*, starrocks::FunctionContext::FunctionStateScope)
    @          0x5d8a1e1 starrocks::ExprContext::open(starrocks::RuntimeState*)
    @          0x5d8c680 starrocks::Expr::open(std::vector<starrocks::ExprContext*, std::allocator<starrocks::ExprContext*> > const&, starrocks::RuntimeState*)
    @          0x4e4fc86 starrocks::pipeline::ProjectOperatorFactory::prepare(starrocks::RuntimeState*)
    @          0x5009ded starrocks::pipeline::NormalExecutionGroup::prepare_pipelines(starrocks::RuntimeState*)
    @          0x4f42996 starrocks::pipeline::FragmentContext::prepare_all_pipelines()
    @          0x4e2da6e starrocks::pipeline::FragmentExecutor::_prepare_pipeline_driver(starrocks::ExecEnv*, starrocks::pipeline::UnifiedExecPlanFragmentParams const&)
    @          0x4e31acd starrocks::pipeline::FragmentExecutor::prepare(starrocks::ExecEnv*, starrocks::TExecPlanFragmentParams const&, starrocks::TExecPlanFragmentParams const&)
    @          0x7a9ad86 starrocks::PInternalServiceImplBase<starrocks::PInternalService>::_exec_plan_fragment_by_pipeline(starrocks::TExecPlanFragmentParams const&, starrocks::TExecPlanFragmentParams const&)
    @          0x7aa0d95 starrocks::PInternalServiceImplBase<starrocks::PInternalService>::_exec_plan_fragment(brpc::Controller*, starrocks::PExecPlanFragmentRequest const*)
    @          0x7aab7cf starrocks::PInternalServiceImplBase<starrocks::PInternalService>::_exec_plan_fragment(google::protobuf::RpcController*, starrocks::PExecPlanFragmentRequest const*, starrocks::PExecPlanFragmentResult*, google::protobuf::Closure*)
    @          0x7943f0d starrocks::PriorityThreadPool::work_thread(int)
    @          0x8e0f93b thread_proxy

What I'm doing:

close #52748

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: stdpain <drfeng08@gmail.com>
Copy link

github-actions bot commented Nov 8, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Nov 8, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Nov 8, 2024

[BE Incremental Coverage Report]

pass : 5 / 5 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exprs/expr_context.cpp 5 5 100.00% []

@LiShuMing LiShuMing merged commit 130facd into StarRocks:main Nov 11, 2024
65 of 66 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Nov 11, 2024
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 11, 2024
Copy link

@Mergifyio backport branch-3.1

Copy link

@Mergifyio backport branch-3.0

Copy link

@Mergifyio backport branch-2.5

Copy link
Contributor

mergify bot commented Nov 11, 2024

backport branch-3.3

✅ Backports have been created

@github-actions github-actions bot removed the 2.5 label Nov 11, 2024
Copy link
Contributor

mergify bot commented Nov 11, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Nov 11, 2024

backport branch-3.1

✅ Backports have been created

Copy link
Contributor

mergify bot commented Nov 11, 2024

backport branch-3.0

✅ Backports have been created

Copy link
Contributor

mergify bot commented Nov 11, 2024

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 11, 2024
…2752)

Signed-off-by: stdpain <drfeng08@gmail.com>
(cherry picked from commit 130facd)
mergify bot pushed a commit that referenced this pull request Nov 11, 2024
…2752)

Signed-off-by: stdpain <drfeng08@gmail.com>
(cherry picked from commit 130facd)
mergify bot pushed a commit that referenced this pull request Nov 11, 2024
…2752)

Signed-off-by: stdpain <drfeng08@gmail.com>
(cherry picked from commit 130facd)
mergify bot pushed a commit that referenced this pull request Nov 11, 2024
…2752)

Signed-off-by: stdpain <drfeng08@gmail.com>
(cherry picked from commit 130facd)
mergify bot pushed a commit that referenced this pull request Nov 11, 2024
…2752)

Signed-off-by: stdpain <drfeng08@gmail.com>
(cherry picked from commit 130facd)
wanpengfei-git pushed a commit that referenced this pull request Nov 11, 2024
…ckport #52752) (#52772)

Co-authored-by: stdpain <34912776+stdpain@users.noreply.github.com>
wanpengfei-git pushed a commit that referenced this pull request Nov 11, 2024
…ckport #52752) (#52773)

Co-authored-by: stdpain <34912776+stdpain@users.noreply.github.com>
wanpengfei-git pushed a commit that referenced this pull request Nov 11, 2024
…ckport #52752) (#52774)

Co-authored-by: stdpain <34912776+stdpain@users.noreply.github.com>
wanpengfei-git pushed a commit that referenced this pull request Nov 11, 2024
…ckport #52752) (#52776)

Co-authored-by: stdpain <34912776+stdpain@users.noreply.github.com>
@stdpain stdpain deleted the fix_expr_open_crash branch December 4, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Execute specific 'case when' be will crash
4 participants