Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Refactor Starrocks LOG to reduce the log file size(part2) #52129

Merged
merged 4 commits into from
Oct 24, 2024
Merged

[Refactor] Refactor Starrocks LOG to reduce the log file size(part2) #52129

merged 4 commits into from
Oct 24, 2024

Conversation

sevev
Copy link
Contributor

@sevev sevev commented Oct 21, 2024

Why I'm doing:

Refactor Starrocks LOG to reduce the log file size

What I'm doing:

Refactor Starrocks BE LOG to reduce the log file size

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

sevev added 2 commits October 21, 2024 10:44
@sevev
refactor pk log in shared_nothing mode
248c847 
Signed-off-by: sevev <qiangzh95@gmail.com>
@sevev
ingestion && execution
a17315c 
Signed-off-by: sevev <qiangzh95@gmail.com>
@sevev sevev requested review from a team as code owners October 21, 2024 02:48
@mergify mergify bot assigned sevev Oct 21, 2024
@sevev
task
c52a24e 
Signed-off-by: sevev <qiangzh95@gmail.com>

format

Signed-off-by: sevev <qiangzh95@gmail.com>

format

Signed-off-by: sevev <qiangzh95@gmail.com>
decster
decster previously approved these changes Oct 21, 2024
View reviewed changes
stdpain
stdpain previously approved these changes Oct 21, 2024
View reviewed changes
wyb
wyb reviewed Oct 22, 2024
View reviewed changes
be/src/exec/pipeline/pipeline_driver_executor.cpp Show resolved Hide resolved
be/src/storage/compaction_task.cpp Outdated Show resolved Hide resolved
be/src/storage/tablet_updates.cpp Outdated Show resolved Hide resolved
@sevev sevev dismissed stale reviews from stdpain and decster via f3caf1c October 23, 2024 09:27
wyb
wyb previously approved these changes Oct 23, 2024
View reviewed changes
@sevev
update
f26a1c0 
Signed-off-by: sevev <qiangzh95@gmail.com>
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

❌ fail : 82 / 154 (53.25%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/task/engine_clone_task.cpp 0 1 00.00% [170]
🔵 be/src/agent/agent_task.cpp 5 23 21.74% [438, 445, 453, 454, 511, 512, 654, 661, 689, 690, 695, 725, 726, 731, 785, 834, 861, 916]
🔵 be/src/storage/persistent_index.cpp 6 26 23.08% [709, 710, 1347, 1355, 1362, 2132, 2133, 2450, 2478, 3836, 3837, 3867, 3868, 5171, 5172, 5173, 5174, 5192, 5202, 5203]
🔵 be/src/storage/compaction_task.cpp 5 9 55.56% [41, 42, 117, 145]
🔵 be/src/agent/task_worker_pool.cpp 6 10 60.00% [527, 557, 558, 559]
🔵 be/src/storage/tablet_updates.cpp 37 57 64.91% [693, 694, 695, 1771, 1818, 1819, 1820, 1834, 2164, 2166, 2488, 2709, 2819, 2915, 2917, 2941, 3084, 3085, 3154, 5469]
🔵 be/src/service/internal_service.cpp 3 4 75.00% [448]
🔵 be/src/runtime/plan_fragment_executor.cpp 3 4 75.00% [85]
🔵 be/src/exec/pipeline/pipeline_driver_executor.cpp 5 6 83.33% [447]
🔵 be/src/storage/rowset_update_state.cpp 10 12 83.33% [689, 830]
🔵 be/src/storage/rowset_merger.cpp 1 1 100.00% []
🔵 be/src/storage/storage_engine.cpp 1 1 100.00% []

@wanpengfei-git wanpengfei-git merged commit 16ffabe into StarRocks:main Oct 24, 2024
46 of 47 checks passed
ZiheLiu pushed a commit to ZiheLiu/starrocks that referenced this pull request Oct 31, 2024
@sevev @ZiheLiu
[Refactor] Refactor Starrocks LOG to reduce the log file size(part2) (S…
9bdad83 
…tarRocks#52129)

Signed-off-by: sevev <qiangzh95@gmail.com>
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@sevev @renzhimin7
[Refactor] Refactor Starrocks LOG to reduce the log file size(part2) (S…
29185f3 
…tarRocks#52129)

Signed-off-by: sevev <qiangzh95@gmail.com>
Signed-off-by: zhiminr.ren <1240388654@qq.com>
@sevev
Copy link
Contributor Author

sevev commented Nov 22, 2024

@mergify backport branch-3.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 22, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 22, 2024
@sevev @mergify
[Refactor] Refactor Starrocks LOG to reduce the log file size(part2) (#…
e72246a 
…52129)

Signed-off-by: sevev <qiangzh95@gmail.com>
(cherry picked from commit 16ffabe)

# Conflicts:
#	be/src/exec/pipeline/pipeline_driver_executor.cpp
#	be/src/service/internal_service.cpp
#	be/src/storage/rowset_update_state.cpp
#	be/src/storage/tablet_updates.cpp
@mergify mergify bot mentioned this pull request Nov 22, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Nov 22, 2024
@mergify @sevev
[Refactor] Refactor Starrocks LOG to reduce the log file size(part2) …
b62293d 
…(backport #52129) (#53146)

Signed-off-by: sevev <qiangzh95@gmail.com>
Co-authored-by: zhangqiang <qiangzh95@gmail.com>
@sevev
Copy link
Contributor Author

sevev commented Nov 25, 2024

@mergify backport branch-3.3

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 25, 2024
@sevev @mergify
[Refactor] Refactor Starrocks LOG to reduce the log file size(part2) (#…
93a8bba 
…52129)

Signed-off-by: sevev <qiangzh95@gmail.com>
(cherry picked from commit 16ffabe)

# Conflicts:
#	be/src/common/config.h
#	be/src/storage/tablet_updates.cpp
@mergify mergify bot mentioned this pull request Nov 25, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Nov 27, 2024
@mergify @sevev
[Refactor] Refactor Starrocks LOG to reduce the log file size(part2) …
e749d9b 
…(backport #52129) (#53161)

Signed-off-by: sevev <qiangzh95@gmail.com>
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
Co-authored-by: zhangqiang <qiangzh95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decster decster decster approved these changes

@wyb wyb wyb approved these changes

@stdpain stdpain stdpain left review comments

Assignees

@sevev sevev

Labels
3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sevev @decster @wyb @stdpain @wanpengfei-git