Skip to content

[BugFix] fix fs posix errno mapping rules #51411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2024
Merged

[BugFix] fix fs posix errno mapping rules #51411

merged 1 commit into from
Sep 26, 2024

Conversation

luohaha
Copy link
Contributor

@luohaha luohaha commented Sep 25, 2024

Why I'm doing:

In BE implementation, we will treat IO Error return from fs posix function as this disk met unrecover issue, and BE will try to clean tablet on this disk, so FE can schedule a repair task to fix this replica.
So the rules about errno mapping to status will be crucial.

What I'm doing:

Distinguish between these error codes : EIO, ENOSPC. Only return IO Error when meet EIO.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@luohaha
[BugFix] fix fs posix errno mapping rules
84e42d4 
Signed-off-by: luohaha <18810541851@163.com>
@luohaha luohaha requested a review from a team as a code owner September 25, 2024 17:36
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

❌ fail : 1 / 5 (20.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/fs/fs_posix.cpp 1 5 20.00% [100, 101, 106, 107]

@luohaha luohaha merged commit 6b5973a into StarRocks:main Sep 26, 2024
50 of 51 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 26, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Sep 26, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Sep 26, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 26, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 26, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 26, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 26, 2024
@luohaha @mergify
[BugFix] fix fs posix errno mapping rules (#51411)
5342d0e 
Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit 6b5973a)
mergify bot pushed a commit that referenced this pull request Sep 26, 2024
@luohaha @mergify
[BugFix] fix fs posix errno mapping rules (#51411)
ebf8b8a 
Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit 6b5973a)
This was referenced Sep 26, 2024
Merged
Merged
@luohaha
Copy link
Contributor Author

luohaha commented Sep 26, 2024

https://github.com/Mergifyio backport branch-3.3.4

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 26, 2024 •
edited
Loading

backport branch-3.3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 26, 2024
@luohaha @mergify
[BugFix] fix fs posix errno mapping rules (#51411)
2c52e94 
Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit 6b5973a)
@mergify mergify bot mentioned this pull request Sep 26, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Sep 26, 2024
@luohaha @mergify
[BugFix] fix fs posix errno mapping rules (#51411)
ae867d6 
Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit 6b5973a)
@mergify mergify bot mentioned this pull request Sep 26, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Sep 26, 2024
@mergify @luohaha
[BugFix] fix fs posix errno mapping rules (backport #51411) (#51422)
563181a 
Co-authored-by: Yixin Luo <18810541851@163.com>
wanpengfei-git pushed a commit that referenced this pull request Sep 26, 2024
@mergify @luohaha
[BugFix] fix fs posix errno mapping rules (backport #51411) (#51423)
02a91c6 
Co-authored-by: Yixin Luo <18810541851@163.com>
wanpengfei-git pushed a commit that referenced this pull request Sep 26, 2024
@mergify @luohaha
[BugFix] fix fs posix errno mapping rules (backport #51411) (#51425)
3b191a6 
Co-authored-by: Yixin Luo <18810541851@163.com>
wanpengfei-git pushed a commit that referenced this pull request Sep 26, 2024
@mergify @luohaha
[BugFix] fix fs posix errno mapping rules (backport #51411) (#51424)
3cfc66f 
Signed-off-by: Yixin Luo <18810541851@163.com>
Co-authored-by: Yixin Luo <18810541851@163.com>
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@luohaha @renzhimin7
[BugFix] fix fs posix errno mapping rules (StarRocks#51411)
15f7e24 
Signed-off-by: luohaha <18810541851@163.com>
Signed-off-by: zhiminr.ren <1240388654@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincai kevincai kevincai approved these changes

@wyb wyb wyb approved these changes

@chaoyli chaoyli chaoyli approved these changes

Assignees

@luohaha luohaha

Labels
3.1-merged 3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luohaha @kevincai @wyb @chaoyli