Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Add replication_num in exception message when chosen backends failed in creating tablet #51401

Merged
merged 1 commit into from
Sep 26, 2024
Merged

[Enhancement] Add replication_num in exception message when chosen backends failed in creating tablet #51401

merged 1 commit into from
Sep 26, 2024

Conversation

xiangguangyxg
Copy link
Contributor

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@xiangguangyxg
[Enhancement] Add replication_num in log when chosen backend failed i…
fe2bc0c 
…n creating tablet

Signed-off-by: xiangguangyxg <xiangguangyxg@gmail.com>
@github-actions github-actions bot added the 3.3 label Sep 25, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/server/LocalMetastore.java 2 2 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@xiangguangyxg xiangguangyxg changed the title [Enhancement] Add replication_num in log when chosen backend failed in creating tablet [Enhancement] Add replication_num in exception message when chosen backends failed in creating tablet Sep 26, 2024
@wyb wyb enabled auto-merge (squash) September 26, 2024 02:22
@wyb wyb merged commit 6083ecd into StarRocks:main Sep 26, 2024
54 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 26, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 26, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 26, 2024
@xiangguangyxg @mergify
[Enhancement] Add replication_num in exception message when chosen ba…
5728c10 
…ckends failed in creating tablet (#51401)

Signed-off-by: xiangguangyxg <xiangguangyxg@gmail.com>
(cherry picked from commit 6083ecd)
@mergify mergify bot mentioned this pull request Sep 26, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Sep 26, 2024
@mergify @xiangguangyxg
[Enhancement] Add replication_num in exception message when chosen ba…
2310671 
…ckends failed in creating tablet (backport #51401) (#51415)

Co-authored-by: xiangguangyxg <110401425+xiangguangyxg@users.noreply.github.com>
@xiangguangyxg xiangguangyxg deleted the log_replication_num branch September 26, 2024 05:24
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@xiangguangyxg @renzhimin7
[Enhancement] Add replication_num in exception message when chosen ba…
ad2740b 
…ckends failed in creating tablet (StarRocks#51401)

Signed-off-by: xiangguangyxg <xiangguangyxg@gmail.com>
Signed-off-by: zhiminr.ren <1240388654@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincai kevincai kevincai approved these changes

@wyb wyb wyb approved these changes

Assignees

@xiangguangyxg xiangguangyxg

Labels
3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiangguangyxg @kevincai @wyb