[BugFix] Fix compaction flat json crash #51307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seaven <seaven_7@qq.com>
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]❌ fail : 3 / 8 (37.50%) file detail
|
stdpain
reviewed
Sep 24, 2024
| @@ -244,7 +244,8 @@ std::string append_read_name(const ColumnReader* col_reader) { | |||
| for (const auto& sub_reader : *col_reader->sub_readers()) { | |||
| stream << fmt::format("{}({}), ", sub_reader->name(), type_to_string(sub_reader->column_type())); | |||
| } | |||
| return stream.str().substr(0, stream.view().size() - 2); | |||
| auto str = stream.str(); | |||
| return str.substr(0, str.size() - 2); | |||
There was a problem hiding this comment.
need c++20, some env doesn't support
kangkaisen
approved these changes
Sep 24, 2024
dirtysalt
approved these changes
Sep 24, 2024
wyb
approved these changes
Sep 24, 2024
|
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
Signed-off-by: Seaven <seaven_7@qq.com> (cherry picked from commit 1ab795f)
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 25, 2024
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
Signed-off-by: Seaven <seaven_7@qq.com> Signed-off-by: zhiminr.ren <1240388654@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
check condition lose
What I'm doing:
Fixes https://github.com/StarRocks/StarRocksTest/issues/8606
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: