Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix stream load load_finish_time updated unexpected after transaction committed (backport #51174) #51265

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 23, 2024

Why I'm doing:

mysql> select * from _statistics_.loads_history where label='stream_load_1726737200632_4eM'\G;
*************************** 1. row ***************************
                  id: 20038
               label: stream_load_1726737200632_4eM
          profile_id: NULL
             db_name: ingestion_db
          table_name: duplicate_200_column_7CR
                user: root
           warehouse: NULL
               state: COMMITED
            progress: 0%
                type: STREAM_LOAD
            priority: NORMAL
           scan_rows: 0
          scan_bytes: -1
       filtered_rows: -1
     unselected_rows: -1
           sink_rows: -1
     runtime_details: {"begin_txn_time_ms": 0, "client_ip": "172.26.93.220", "load_id": "6648aa87-3649-e16b-8446-79b1dbf473b5", "plan_time_ms": 0, "receive_data_time_ms": 0, "txn_id": 8234}
         create_time: 2024-09-19 17:13:20
     load_start_time: NULL
    load_commit_time: NULL
    load_finish_time: 2024-09-19 17:13:46
          properties: {"timeout": 3600}
           error_msg: NULL
        tracking_sql: select tracking_log from information_schema.load_tracking_logs where job_id=20038
rejected_record_path: NULL
              job_id: 20038
*************************** 2. row ***************************
                  id: 20038
               label: stream_load_1726737200632_4eM
          profile_id: NULL
             db_name: ingestion_db
          table_name: duplicate_200_column_7CR
                user: root
           warehouse: NULL
               state: FINISHED
            progress: 100%
                type: STREAM_LOAD
            priority: NORMAL
           scan_rows: 0
          scan_bytes: 4849
       filtered_rows: 0
     unselected_rows: 0
           sink_rows: 1
     runtime_details: {"begin_txn_time_ms": 0, "client_ip": "172.26.93.220", "load_id": "6648aa87-3649-e16b-8446-79b1dbf473b5", "plan_time_ms": 8, "receive_data_time_ms": 0, "txn_id": 8234}
         create_time: 2024-09-19 17:13:20
     load_start_time: NULL
    load_commit_time: NULL
    load_finish_time: 2024-09-19 17:16:10
          properties: {"timeout": 3600}
           error_msg:
        tracking_sql: NULL
rejected_record_path: NULL
              job_id: 20038
2 rows in set (0.02 sec)

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #51174 done by [Mergify](https://mergify.com). ## Why I'm doing: ``` mysql> select * from _statistics_.loads_history where label='stream_load_1726737200632_4eM'\G; *************************** 1. row *************************** id: 20038 label: stream_load_1726737200632_4eM profile_id: NULL db_name: ingestion_db table_name: duplicate_200_column_7CR user: root warehouse: NULL state: COMMITED progress: 0% type: STREAM_LOAD priority: NORMAL scan_rows: 0 scan_bytes: -1 filtered_rows: -1 unselected_rows: -1 sink_rows: -1 runtime_details: {"begin_txn_time_ms": 0, "client_ip": "172.26.93.220", "load_id": "6648aa87-3649-e16b-8446-79b1dbf473b5", "plan_time_ms": 0, "receive_data_time_ms": 0, "txn_id": 8234} create_time: 2024-09-19 17:13:20 load_start_time: NULL load_commit_time: NULL load_finish_time: 2024-09-19 17:13:46 properties: {"timeout": 3600} error_msg: NULL tracking_sql: select tracking_log from information_schema.load_tracking_logs where job_id=20038 rejected_record_path: NULL job_id: 20038 *************************** 2. row *************************** id: 20038 label: stream_load_1726737200632_4eM profile_id: NULL db_name: ingestion_db table_name: duplicate_200_column_7CR user: root warehouse: NULL state: FINISHED progress: 100% type: STREAM_LOAD priority: NORMAL scan_rows: 0 scan_bytes: 4849 filtered_rows: 0 unselected_rows: 0 sink_rows: 1 runtime_details: {"begin_txn_time_ms": 0, "client_ip": "172.26.93.220", "load_id": "6648aa87-3649-e16b-8446-79b1dbf473b5", "plan_time_ms": 8, "receive_data_time_ms": 0, "txn_id": 8234} create_time: 2024-09-19 17:13:20 load_start_time: NULL load_commit_time: NULL load_finish_time: 2024-09-19 17:16:10 properties: {"timeout": 3600} error_msg: tracking_sql: NULL rejected_record_path: NULL job_id: 20038 2 rows in set (0.02 sec) ```

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…ansaction committed (#51174)

Signed-off-by: meegoo <meegoo.sr@gmail.com>
(cherry picked from commit 49ef20f)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/load/streamload/StreamLoadTask.java
#	fe/fe-core/src/test/java/com/starrocks/load/streamload/StreamLoadManagerTest.java
@mergify mergify bot added the conflicts label Sep 23, 2024
Copy link
Contributor Author

mergify bot commented Sep 23, 2024

Cherry-pick of 49ef20f has failed:

On branch mergify/bp/branch-3.2/pr-51174
Your branch is up to date with 'origin/branch-3.2'.

You are currently cherry-picking commit 49ef20f904.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/load/streamload/StreamLoadTask.java
	both modified:   fe/fe-core/src/test/java/com/starrocks/load/streamload/StreamLoadManagerTest.java

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Sep 23, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot closed this Sep 23, 2024
@meegoo meegoo reopened this Sep 27, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) September 27, 2024 06:52
Signed-off-by: meegoo <meegoo.sr@gmail.com>
Signed-off-by: meegoo <meegoo.sr@gmail.com>
@meegoo meegoo disabled auto-merge September 27, 2024 07:50
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) September 27, 2024 07:50
Copy link

@wanpengfei-git wanpengfei-git merged commit dd842e8 into branch-3.2 Sep 27, 2024
28 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-51174 branch September 27, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants