Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] remove static Column #50983

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

silverbullet233
Copy link
Contributor

@silverbullet233 silverbullet233 commented Sep 12, 2024

Why I'm doing:

img_v3_02ek_0552bc4d-d932-4b71-a1d2-c2761fed6fcg

What I'm doing:

We maintain two static ColumnPtr in ColumnHelper, which will be used by ColumnViewer.
However, the allocator of column buffer depends on thread local variables, and the life cycle of thread local variables is shorter than that of static variables, which will cause ASAN to report the above error.

Solution: Move static variables to the GlobalVariables

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: silverbullet233 <3675229+silverbullet233@users.noreply.github.com>
Signed-off-by: silverbullet233 <3675229+silverbullet233@users.noreply.github.com>
@silverbullet233 silverbullet233 force-pushed the remove_static_column branch 2 times, most recently from 87d420b to 110a771 Compare September 25, 2024 05:37
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 22 / 22 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/column/column_viewer.cpp 3 3 100.00% []
🔵 be/src/runtime/global_variables.h 11 11 100.00% []
🔵 be/src/service/service_be/starrocks_be.cpp 3 3 100.00% []
🔵 be/src/runtime/global_variables.cpp 5 5 100.00% []

@silverbullet233 silverbullet233 enabled auto-merge (squash) September 25, 2024 08:42
@silverbullet233 silverbullet233 merged commit 24cdbd1 into StarRocks:main Sep 26, 2024
85 of 86 checks passed
@silverbullet233 silverbullet233 deleted the remove_static_column branch September 26, 2024 02:40
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
Signed-off-by: silverbullet233 <3675229+silverbullet233@users.noreply.github.com>
Signed-off-by: zhiminr.ren <1240388654@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants