Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix][FlatJson] Fix flat json bugs #50223

Merged
merged 2 commits into from
Aug 27, 2024
Merged

[BugFix][FlatJson] Fix flat json bugs #50223

merged 2 commits into from
Aug 27, 2024

Conversation

Seaven
Copy link
Contributor

@Seaven Seaven commented Aug 23, 2024

Why I'm doing:

  • Fix flat json time profile lose
  • Fix flat json choose subfield strategy
    • first sort by sparsity factor, then column name
  • Fix flat json function concurrent bug
    • json function context init flag set early

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: Seaven <seaven_7@qq.com>
@Seaven Seaven requested review from a team as code owners August 23, 2024 13:10
@mergify mergify bot assigned Seaven Aug 23, 2024
@github-actions github-actions bot added the 3.3 label Aug 23, 2024
@Seaven Seaven requested a review from a team as a code owner August 26, 2024 11:22
@Seaven Seaven changed the title [Enhancement][FlatJson] Fix flat json time profile lose [Enhancement][FlatJson] Fix flat json bugs Aug 26, 2024
Signed-off-by: Seaven <seaven_7@qq.com>
@Seaven Seaven changed the title [Enhancement][FlatJson] Fix flat json bugs [BugFix][FlatJson] Fix flat json bugs Aug 26, 2024
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

fail : 12 / 62 (19.35%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/connector/lake_connector.cpp 0 22 00.00% [725, 726, 728, 734, 735, 737, 748, 749, 751, 759, 760, 761, 762, 764, 765, 766, 768, 769, 770, 772, 773, 774]
🔵 be/src/exec/pipeline/scan/olap_chunk_source.cpp 0 23 00.00% [656, 660, 661, 663, 669, 670, 672, 683, 684, 686, 694, 695, 696, 697, 699, 700, 701, 703, 704, 705, 707, 708, 709]
🔵 be/src/util/json_flattener.cpp 6 9 66.67% [514, 517, 518]
🔵 be/src/storage/rowset/json_column_iterator.cpp 4 6 66.67% [137, 138]
🔵 be/src/exprs/json_functions.cpp 2 2 100.00% []

@kangkaisen kangkaisen merged commit f038d01 into StarRocks:main Aug 27, 2024
66 of 67 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Aug 27, 2024
Copy link
Contributor

mergify bot commented Aug 27, 2024

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 27, 2024
wanpengfei-git pushed a commit that referenced this pull request Aug 29, 2024
va-os-commits pushed a commit to va-os-commits/starrocks that referenced this pull request Sep 10, 2024
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
Signed-off-by: zhiminr.ren <1240388654@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants