[BugFix] Fix pipe insert sql does not have credentials #49837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyb
changed the title
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AstToStringBuilder.java
Show resolved
Hide resolved
wyb
force-pushed
the
pipe_insert_sql_credential
branch
from
ee24a11 to
709e66d
Compare
Signed-off-by: wyb <wybb86@gmail.com>
wyb
force-pushed
the
pipe_insert_sql_credential
branch
from
709e66d to
4b2617a
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 26 / 27 (96.30%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Seaven
approved these changes
Aug 15, 2024
meegoo
approved these changes
Aug 15, 2024
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
Signed-off-by: wyb <wybb86@gmail.com> (cherry picked from commit 382932f) # Conflicts: # fe/fe-core/src/test/java/com/starrocks/sql/plan/SelectUsingAliasTest.java
44 tasks
mergify bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
Signed-off-by: wyb <wybb86@gmail.com> (cherry picked from commit 382932f) # Conflicts: # fe/fe-core/src/test/java/com/starrocks/sql/plan/SelectUsingAliasTest.java
44 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Aug 15, 2024
…) (#49860) Co-authored-by: wyb <wybb86@gmail.com>
wanpengfei-git
pushed a commit
that referenced
this pull request
Aug 15, 2024
…) (#49861) Co-authored-by: wyb <wybb86@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
PipeusesAstToSQLBuilder.toSQLto create insert SQL, and the default behavior ofAstToSQLBuilder.toSQLis to remove the credential, which will cause the pipe task to be abnormal.What I'm doing:
add new function
AstToSQLBuilder.toSQLWithCredentialto retain credentials.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Documentation PRs only:
If you are submitting a PR that adds or changes English documentation and have not
included Chinese documentation, then you can check the box to request GPT to translate the
English doc to Chinese. Please ensure to uncheck the Do not translate box if translation is needed.
The workflow will generate a new PR with the Chinese translation after this PR is merged.