[Enhancement]aws sdk get/put object support zero copy #49709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zombee0 <ewang2027@gmail.com>
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
Signed-off-by: zombee0 <ewang2027@gmail.com>
trueeyu
reviewed
Aug 13, 2024
DorianZheng
reviewed
Aug 13, 2024
| body.read(static_cast<char*>(out), count); | ||
| _offset += body.gcount(); | ||
| return body.gcount(); | ||
| _offset += real_length; |
There was a problem hiding this comment.
Why not reuse outcome.GetResult().GetBody().gcount()? Can we make sure it always equal to real_length?
There was a problem hiding this comment.
iostream's gcount is set after extract operation(like read), we didn't call read at all(we used to call body.read(xxx), and we can set the correct offset even if we had a wrong range #49692)
DorianZheng
reviewed
Aug 13, 2024
trueeyu
previously approved these changes
Aug 13, 2024
Signed-off-by: zombee0 <ewang2027@gmail.com>
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 17 / 18 (94.44%) file detail
|
trueeyu
approved these changes
Aug 14, 2024
DorianZheng
approved these changes
Aug 14, 2024
decster
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
largely reduced memory copy.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Documentation PRs only:
If you are submitting a PR that adds or changes English documentation and have not
included Chinese documentation, then you can check the box to request GPT to translate the
English doc to Chinese. Please ensure to uncheck the Do not translate box if translation is needed.
The workflow will generate a new PR with the Chinese translation after this PR is merged.