Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix incorrect compaction status show in JSON format #49376

Merged
merged 2 commits into from
Aug 8, 2024
Merged

[BugFix] Fix incorrect compaction status show in JSON format #49376

merged 2 commits into from
Aug 8, 2024

Conversation

srlch
Copy link
Contributor

@srlch srlch commented Aug 5, 2024 •
edited
Loading

Currently, compaction status for primary key table will always return NULL

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@srlch
[BugFix] Fix incorrect compaction status show in JSON format
9629b4d 
Signed-off-by: srlch <linzichao@starrocks.com>
@srlch srlch requested a review from a team as a code owner August 5, 2024 05:07
@mergify mergify bot assigned srlch Aug 5, 2024
sevev
sevev previously approved these changes Aug 5, 2024
View reviewed changes
@wyb
Copy link
Contributor

wyb commented Aug 5, 2024

Add ut？

@srlch
fix
58cba8d 
Signed-off-by: srlch <linzichao@starrocks.com>
@srlch
Copy link
Contributor Author

srlch commented Aug 8, 2024

Add ut？

updated

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

[BE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/tablet_updates.cpp 1 1 100.00% []

@wyb wyb merged commit d682471 into StarRocks:main Aug 8, 2024
45 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Aug 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

@Mergifyio backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 8, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 8, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 8, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 8, 2024
@srlch @mergify
[BugFix] Fix incorrect compaction status show in JSON format (#49376)
91c7eda 
Signed-off-by: srlch <linzichao@starrocks.com>
(cherry picked from commit d682471)
@mergify mergify bot mentioned this pull request Aug 8, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Aug 8, 2024
@srlch @mergify
[BugFix] Fix incorrect compaction status show in JSON format (#49376)
0198c2a 
Signed-off-by: srlch <linzichao@starrocks.com>
(cherry picked from commit d682471)
@mergify mergify bot mentioned this pull request Aug 8, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Aug 8, 2024
@srlch @mergify
[BugFix] Fix incorrect compaction status show in JSON format (#49376)
e1f6a6c 
Signed-off-by: srlch <linzichao@starrocks.com>
(cherry picked from commit d682471)

# Conflicts:
#	be/src/storage/tablet_updates.cpp
@mergify mergify bot mentioned this pull request Aug 8, 2024
Closed
42 tasks
srlch added a commit to srlch/starrocks that referenced this pull request Aug 8, 2024
@srlch
[BugFix] Fix incorrect compaction status show in JSON format (StarRoc…
cf84eff 
…ks#49376)

Signed-off-by: srlch <linzichao@starrocks.com>
@github-actions github-actions bot added the 3.1 label Aug 8, 2024
wanpengfei-git pushed a commit that referenced this pull request Aug 8, 2024
@mergify @srlch
[BugFix] Fix incorrect compaction status show in JSON format (backport …
f9dbba7 
…#49376) (#49572)

Co-authored-by: srlch <111035020+srlch@users.noreply.github.com>
wanpengfei-git pushed a commit that referenced this pull request Aug 9, 2024
@mergify @srlch
[BugFix] Fix incorrect compaction status show in JSON format (backport …
2193edd 
…#49376) (#49571)

Co-authored-by: srlch <111035020+srlch@users.noreply.github.com>
wyb pushed a commit that referenced this pull request Aug 9, 2024
@srlch
[BugFix] Fix incorrect compaction status show in JSON format (backport …
5fc083a 
…#49376) (#49574)

Signed-off-by: srlch <linzichao@starrocks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyb wyb wyb approved these changes

@sevev sevev sevev approved these changes

Assignees

@srlch srlch

Labels
3.1-merged 3.1 3.2-merged 3.2 3.3-merged 3.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srlch @wyb @sevev