Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] add trace for MVTextRewrite in optimizer #49227

Merged
merged 2 commits into from
Aug 7, 2024
Merged

[Enhancement] add trace for MVTextRewrite in optimizer #49227

merged 2 commits into from
Aug 7, 2024

Conversation

murphyatwork
Copy link
Contributor

@murphyatwork murphyatwork commented Jul 31, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@murphyatwork murphyatwork requested a review from a team as a code owner July 31, 2024 08:01
packy92
packy92 previously approved these changes Jul 31, 2024
View reviewed changes
LiShuMing
LiShuMing previously approved these changes Jul 31, 2024
View reviewed changes
@murphyatwork
add trace for MVTextRewrite in optimizer
e6fcd08 
Signed-off-by: Murphy <mofei@starrocks.com>
@murphyatwork murphyatwork dismissed stale reviews from LiShuMing and packy92 via e6fcd08 August 5, 2024 04:48
@murphyatwork murphyatwork force-pushed the murphy_fix_optimizer_trace branch from 9bc7bd5 to e6fcd08 Compare August 5, 2024 04:48
@murphyatwork murphyatwork enabled auto-merge (squash) August 5, 2024 07:23
LiShuMing
LiShuMing previously approved these changes Aug 5, 2024
View reviewed changes
@murphyatwork
Merge branch 'main' into murphy_fix_optimizer_trace
a192d56 
Signed-off-by: Murphy <96611012+murphyatwork@users.noreply.github.com>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

[FE Incremental Coverage Report]

✅ pass : 3 / 3 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/Optimizer.java 3 3 100.00% []

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@murphyatwork murphyatwork merged commit cd9b8f3 into StarRocks:main Aug 7, 2024
45 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Aug 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

@Mergifyio backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 7, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 7, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 7, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 7, 2024
@murphyatwork @mergify
[Enhancement] add trace for MVTextRewrite in optimizer (#49227)
acd9ba0 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit cd9b8f3)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/Optimizer.java
@mergify mergify bot mentioned this pull request Aug 7, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Aug 7, 2024
@murphyatwork @mergify
[Enhancement] add trace for MVTextRewrite in optimizer (#49227)
cc237ff 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit cd9b8f3)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/scheduler/PartitionBasedMvRefreshProcessorOlapTest.java
@mergify mergify bot mentioned this pull request Aug 7, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Aug 7, 2024
@murphyatwork @mergify
[Enhancement] add trace for MVTextRewrite in optimizer (#49227)
4d2e4aa 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit cd9b8f3)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/Optimizer.java
#	fe/fe-core/src/test/java/com/starrocks/scheduler/PartitionBasedMvRefreshProcessorOlapTest.java
@mergify mergify bot mentioned this pull request Aug 7, 2024
Closed
42 tasks
murphyatwork added a commit that referenced this pull request Aug 8, 2024
@murphyatwork
[Enhancement] add trace for MVTextRewrite in optimizer (#49227)
c702a04 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit cd9b8f3)
murphyatwork added a commit that referenced this pull request Aug 8, 2024
@murphyatwork
[Enhancement] add trace for MVTextRewrite in optimizer (#49227)
44cd8a0 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit cd9b8f3)
@github-actions github-actions bot removed the 3.1 label Aug 8, 2024
wanpengfei-git pushed a commit that referenced this pull request Aug 8, 2024
@mergify @murphyatwork
[Enhancement] add trace for MVTextRewrite in optimizer (backport #49227…
76ddbab 
…) (#49515)

Co-authored-by: Murphy <96611012+murphyatwork@users.noreply.github.com>
wanpengfei-git pushed a commit that referenced this pull request Aug 8, 2024
@mergify @murphyatwork
[Enhancement] add trace for MVTextRewrite in optimizer (backport #49227…
56a7a7d 
…) (#49514)

Signed-off-by: Murphy <96611012+murphyatwork@users.noreply.github.com>
Co-authored-by: Murphy <96611012+murphyatwork@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiShuMing LiShuMing LiShuMing approved these changes

@before-Sunrise before-Sunrise before-Sunrise approved these changes

@packy92 packy92 packy92 approved these changes

Assignees

@murphyatwork murphyatwork

Labels
3.2-merged 3.2 3.3-merged 3.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@murphyatwork @LiShuMing @before-Sunrise @packy92