Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix]deal with pageindex before collect_io_range of data page #49066

Merged
merged 3 commits into from
Aug 2, 2024
Merged

[BugFix]deal with pageindex before collect_io_range of data page #49066

merged 3 commits into from
Aug 2, 2024

Conversation

zombee0
Copy link
Contributor

@zombee0 zombee0 commented Jul 29, 2024

Why I'm doing:

What I'm doing:

we need deal with pageindex first, so that we can collect io based on pageindex.

Fixes #issue
introduced by
#44666

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@zombee0
[BugFix]deal with pageindex before collect_io_range of data page
0ae897f 
Signed-off-by: zombee0 <ewang2027@gmail.com>
@zombee0 zombee0 requested review from a team as code owners July 29, 2024 08:29
@github-actions github-actions bot added the 3.3 label Jul 29, 2024
@zombee0
format
f83723e 
Signed-off-by: zombee0 <ewang2027@gmail.com>
dirtysalt
dirtysalt previously approved these changes Jul 29, 2024
View reviewed changes
@zombee0
refact the procedure of group init, pageindex, collect io, rewrite
065827c 
Signed-off-by: zombee0 <ewang2027@gmail.com>
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 27 / 28 (96.43%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/formats/parquet/group_reader.cpp 18 19 94.74% [443]
🔵 be/src/formats/parquet/group_reader.h 1 1 100.00% []
🔵 be/src/formats/parquet/file_reader.cpp 3 3 100.00% []
🔵 be/src/io/shared_buffered_input_stream.cpp 5 5 100.00% []

@wyb wyb merged commit a242dde into StarRocks:main Aug 2, 2024
48 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Aug 2, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 2, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 2, 2024
@zombee0 @mergify
[BugFix]deal with pageindex before collect_io_range of data page (#49066
79fbdaf 
)

Signed-off-by: zombee0 <ewang2027@gmail.com>
(cherry picked from commit a242dde)

# Conflicts:
#	be/src/formats/parquet/file_reader.h
@mergify mergify bot mentioned this pull request Aug 2, 2024
Closed
42 tasks
zombee0 added a commit to zombee0/starrocks that referenced this pull request Aug 2, 2024
@zombee0
[BugFix]deal with pageindex before collect_io_range of data page (Sta…
652f0aa 
…rRocks#49066)

Signed-off-by: zombee0 <ewang2027@gmail.com>
dirtysalt pushed a commit that referenced this pull request Aug 8, 2024
@zombee0
[BugFix]deal with pageindex before collect_io_range of data page (bac…
6159a33 
…kport #49066) (#49316)

Signed-off-by: zombee0 <ewang2027@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyb wyb wyb approved these changes

@dirtysalt dirtysalt dirtysalt approved these changes

@trueeyu trueeyu trueeyu approved these changes

Assignees

@zombee0 zombee0

Labels
3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zombee0 @wyb @dirtysalt @trueeyu