Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix check of plan timeout in SeriallyTaskScheduler #48405

Merged
merged 4 commits into from
Jul 16, 2024
Merged

[BugFix] Fix check of plan timeout in SeriallyTaskScheduler #48405

merged 4 commits into from
Jul 16, 2024

Conversation

ZiheLiu
Copy link
Contributor

@ZiheLiu ZiheLiu commented Jul 16, 2024

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@ZiheLiu
[BugFix] Fix check of plan timeout in SeriallyTaskScheduler
ee8ac9a 
Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
@ZiheLiu ZiheLiu requested a review from a team as a code owner July 16, 2024 02:48
kangkaisen
kangkaisen previously approved these changes Jul 16, 2024
View reviewed changes
@ZiheLiu
Add UT
5113f31 
Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
@ZiheLiu ZiheLiu force-pushed the fix/main/plan_timeout branch from 7a00dc7 to 5113f31 Compare July 16, 2024 08:52
ZiheLiu added 2 commits July 16, 2024 17:40
@ZiheLiu
s
f041412 
Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
@ZiheLiu
s
57775aa 
Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/task/SeriallyTaskScheduler.java 1 1 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@kangkaisen kangkaisen merged commit 6132193 into StarRocks:main Jul 16, 2024
48 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Jul 16, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Jul 16, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 16, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 16, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 16, 2024
@ZiheLiu @mergify
[BugFix] Fix check of plan timeout in SeriallyTaskScheduler (#48405)
07c725c 
Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
(cherry picked from commit 6132193)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/ReplayFromDumpTest.java
mergify bot pushed a commit that referenced this pull request Jul 16, 2024
@ZiheLiu @mergify
[BugFix] Fix check of plan timeout in SeriallyTaskScheduler (#48405)
7bcd2c4 
Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
(cherry picked from commit 6132193)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/ReplayFromDumpTest.java
This was referenced Jul 16, 2024
Closed
Closed
ZiheLiu added a commit to ZiheLiu/starrocks that referenced this pull request Jul 16, 2024
@ZiheLiu
[BugFix] Fix check of plan timeout in SeriallyTaskScheduler (StarRock…
2621e9f 
…s#48405)

Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
@ZiheLiu ZiheLiu mentioned this pull request Jul 16, 2024
Merged
24 tasks
ZiheLiu added a commit to ZiheLiu/starrocks that referenced this pull request Jul 16, 2024
@ZiheLiu
[BugFix] Fix check of plan timeout in SeriallyTaskScheduler (StarRock…
1dde02f 
…s#48405)

Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
@ZiheLiu ZiheLiu mentioned this pull request Jul 16, 2024
Merged
24 tasks
kangkaisen pushed a commit that referenced this pull request Jul 17, 2024
@ZiheLiu
[BugFix] Fix check of plan timeout in SeriallyTaskScheduler (backport #…
729927a 
…48405) (#48460)

Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
zhangheihei pushed a commit to zhangheihei/starrocks that referenced this pull request Jul 18, 2024
@ZiheLiu @zhangheihei
[BugFix] Fix check of plan timeout in SeriallyTaskScheduler (StarRock…
4fb1559 
…s#48405)

Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
ZiheLiu added a commit that referenced this pull request Jul 24, 2024
@ZiheLiu
[BugFix] Fix check of plan timeout in SeriallyTaskScheduler (backport #…
0dafa01 
…48405) (#48459)

Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
dujijun007 pushed a commit to dujijun007/starrocks that referenced this pull request Jul 29, 2024
@ZiheLiu @dujijun007
[BugFix] Fix check of plan timeout in SeriallyTaskScheduler (StarRock…
dd4a2f5 
…s#48405)

Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangkaisen kangkaisen kangkaisen approved these changes

@Seaven Seaven Seaven approved these changes

Assignees

@ZiheLiu ZiheLiu

Labels
3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZiheLiu @Seaven @kangkaisen