-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] check if BinaryOutputArchive write success #48045
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvin-celerdata
approved these changes
Jul 9, 2024
@mergify rebase |
Signed-off-by: luohaha <18810541851@163.com>
✅ Branch has been successfully rebased |
alvin-celerdata
force-pushed
the
fix-l0-dump
branch
from
July 9, 2024 19:28
131371f
to
02f5e62
Compare
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 2 / 2 (100.00%) file detail
|
24 tasks
https://github.com/Mergifyio backport branch-3.3 |
https://github.com/Mergifyio backport branch-3.2 |
https://github.com/Mergifyio backport branch-3.1 |
✅ Backports have been created
|
✅ Backports have been created
|
https://github.com/Mergifyio backport branch-3.0 |
✅ Backports have been created
|
https://github.com/Mergifyio backport branch-2.5 |
mergify bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
Signed-off-by: luohaha <18810541851@163.com> (cherry picked from commit 0726e39)
42 tasks
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
Signed-off-by: luohaha <18810541851@163.com> (cherry picked from commit 0726e39)
mergify bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
Signed-off-by: luohaha <18810541851@163.com> (cherry picked from commit 0726e39)
This was referenced Jul 10, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
Signed-off-by: luohaha <18810541851@163.com> (cherry picked from commit 0726e39)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
Signed-off-by: luohaha <18810541851@163.com> (cherry picked from commit 0726e39)
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 10, 2024
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 10, 2024
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 10, 2024
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 10, 2024
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 10, 2024
This was referenced Jul 10, 2024
smartlxh
pushed a commit
to smartlxh/starrocks
that referenced
this pull request
Oct 16, 2024
StarRocks#48045) (StarRocks#48076) Co-authored-by: Yixin Luo <18810541851@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Persistent Index
useBinaryOutputArchive
to generatel0
snapshot, and ifBinaryOutputArchive
write fail and return true, it will lead tol0
lost data and cause PK table issue like:What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: