-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Bump simdjson to 3.9.4 and Fix struct field columns inconsistent when loading from bad json #47775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wyb <wybb86@gmail.com>
wyb
changed the title
[BugFix] Fix struct field column inconsistent when loading from bad json
[BugFix] Fix struct field columns inconsistent when loading from bad json
Jul 3, 2024
meegoo
previously approved these changes
Jul 3, 2024
auto-merge was automatically disabled
July 3, 2024 11:26
Pull request was converted to draft
wyb
changed the title
[BugFix] Fix struct field columns inconsistent when loading from bad json
[BugFix] Bump simdjson to 3.9.4 and Fix struct field columns inconsistent when loading from bad json
Jul 4, 2024
Signed-off-by: wyb <wybb86@gmail.com>
meegoo
previously approved these changes
Jul 4, 2024
kevincai
approved these changes
Jul 5, 2024
meegoo
approved these changes
Jul 5, 2024
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 11 / 13 (84.62%) file detail
|
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
ZiheLiu
added a commit
to ZiheLiu/starrocks
that referenced
this pull request
Jul 8, 2024
…inconsistent when loading from bad json (StarRocks#47775)" This reverts commit 3ca24dc.
ZiheLiu
added a commit
to ZiheLiu/starrocks
that referenced
this pull request
Jul 18, 2024
…inconsistent when loading from bad json (StarRocks#47775)" This reverts commit 3ca24dc.
ZiheLiu
added a commit
to ZiheLiu/starrocks
that referenced
this pull request
Jul 31, 2024
…inconsistent when loading from bad json (StarRocks#47775)" This reverts commit 3ca24dc.
ZiheLiu
added a commit
to ZiheLiu/starrocks
that referenced
this pull request
Jul 31, 2024
…inconsistent when loading from bad json (StarRocks#47775)" This reverts commit 3ca24dc.
ZiheLiu
added a commit
to ZiheLiu/starrocks
that referenced
this pull request
Aug 8, 2024
…inconsistent when loading from bad json (StarRocks#47775)" This reverts commit 3ca24dc.
ZiheLiu
added a commit
to ZiheLiu/starrocks
that referenced
this pull request
Aug 9, 2024
…inconsistent when loading from bad json (StarRocks#47775)" This reverts commit 3ca24dc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
find_field_unordered
will crash in current simdjson version when loading from bad json.What I'm doing:
find_field_unordered
crash.Fixes #issue
https://github.com/StarRocks/StarRocksTest/issues/7982
#45406
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: