[Enhancement] support user variable in analytic function #47728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: packy92 <wangchao@starrocks.com>
Signed-off-by: packy92 <wangchao@starrocks.com>
Signed-off-by: packy92 <wangchao@starrocks.com>
Signed-off-by: packy92 <wangchao@starrocks.com>
Signed-off-by: packy92 <wangchao@starrocks.com>
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
| } | ||
|
|
||
| return Optional.empty(); | ||
| } | ||
| } |
There was a problem hiding this comment.
The most risky bug in this code is:
Optional.get() without checking for presence
You can modify the code like this:
if (k.isPresent() && counterNum.isPresent() && k.get() > counterNum.get()) {
throw new SemanticException(
"The second parameter must be smaller than or equal to the third parameter" +
functionCallExpr.toSql(), kExpr.getPos());
}
fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AnalyticAnalyzer.java
Show resolved
Hide resolved
Seaven
previously approved these changes
Jul 2, 2024
kangkaisen
previously approved these changes
Jul 2, 2024
|
[FE Incremental Coverage Report]✅ pass : 37 / 37 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Seaven
approved these changes
Jul 3, 2024
kangkaisen
approved these changes
Jul 3, 2024
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
Signed-off-by: packy92 <wangchao@starrocks.com> (cherry picked from commit 09d8d3a)
mergify bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
Signed-off-by: packy92 <wangchao@starrocks.com> (cherry picked from commit 09d8d3a) # Conflicts: # test/sql/test_hint/R/test_hint # test/sql/test_hint/T/test_hint
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
consider user varibale in constant expr check.
Fixes #47225
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: