Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]prefetch agg_hash_set #47693

Merged
merged 5 commits into from
Jul 10, 2024
Merged

[Enhancement]prefetch agg_hash_set #47693

merged 5 commits into from
Jul 10, 2024

Conversation

zombee0
Copy link
Contributor

@zombee0 zombee0 commented Jul 1, 2024

Why I'm doing:

What I'm doing:

sql old new imporvement
select count (distinct lo_linenumber) from lineorder_flat; 0.70 0.72 0 as expected
SELECT COUNT (DISTINCT s_name) FROM lineorder_flat; 15.83 13.58 16%
select count (distinct lo_suppkey) from lineorder_flat; 2.36 1.81 30%
SELECT COUNT (DISTINCT lo_suppkey) FROM lineorder_flat group by lo_linenumber; 6.23 4.21 48%
SELECT COUNT (DISTINCT lo_suppkey) FROM lineorder_flat group by lo_linenumber, lo_orderpriority; 34.45 32.87 4.8%
SELECT COUNT (DISTINCT lo_suppkey) FROM lineorder_flat group by lo_orderpriority; 26.65 22.27 19%

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@zombee0 zombee0 requested review from a team as code owners July 1, 2024 08:54
@mergify mergify bot assigned zombee0 Jul 1, 2024
@zombee0 zombee0 changed the title [WIP] prehash [Enhancement]prefetch agg_hash_set Jul 1, 2024
Signed-off-by: zombee0 <ewang2027@gmail.com>
Signed-off-by: zombee0 <ewang2027@gmail.com>
dirtysalt
dirtysalt previously approved these changes Jul 4, 2024
@stdpain
Copy link
Contributor

stdpain commented Jul 5, 2024

prefetch may cause performance degradation. refer #4856

@zombee0
Copy link
Contributor Author

zombee0 commented Jul 5, 2024

prefetch may cause performance degradation. refer #4856

yes, there is a prefetch threshold.

…prefetch

Signed-off-by: zombee0 <ewang2027@gmail.com>
Signed-off-by: zombee0 <ewang2027@gmail.com>
Signed-off-by: zombee0 <ewang2027@gmail.com>
@zombee0 zombee0 requested review from dirtysalt and stdpain July 9, 2024 11:54
Copy link

github-actions bot commented Jul 9, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Jul 9, 2024

[BE Incremental Coverage Report]

pass : 118 / 126 (93.65%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/aggregate/agg_hash_set.h 118 126 93.65% [178, 259, 278, 363, 433, 459, 575, 698]

Copy link
Contributor

@LiShuMing LiShuMing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good~

@LiShuMing LiShuMing merged commit 6f08ccb into StarRocks:main Jul 10, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants