Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Optimize IdChain hash code implement #47599

Merged
merged 1 commit into from
Jun 28, 2024
Merged

[Enhancement] Optimize IdChain hash code implement #47599

merged 1 commit into from
Jun 28, 2024

Conversation

gengjun-git
Copy link
Contributor

@gengjun-git gengjun-git commented Jun 27, 2024 •
edited
Loading

Why I'm doing:

The current implement of hashCode is easy to cause conflict. The data in the attachment takes 15 minutes to construct a HashMap<IdChain, IdChain> using the current hashCode implementation, but only takes a few seconds after changing to Arrays.hashCode().

chain.json.tar.gz

What I'm doing:

Fixes #https://github.com/StarRocks/StarRocksTest/issues/5336

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@gengjun-git
opt
b7b5da2 
Signed-off-by: gengjun-git <gengjun@starrocks.com>
@gengjun-git gengjun-git requested a review from a team as a code owner June 27, 2024 12:47
@github-actions github-actions bot added the 2.5 label Jun 27, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/backup/RestoreFileMapping.java 1 1 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@gengjun-git gengjun-git merged commit d6bccdb into StarRocks:main Jun 28, 2024
69 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Jun 28, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Jun 28, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Jun 28, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 28, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 28, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 28, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 28, 2024 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 28, 2024 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 28, 2024
@gengjun-git @mergify
[Enhancement] Optimize IdChain hash code implement (#47599)
a0e9b6c 
The current implement of hashCode is easy to cause conflict. The data in the attachment takes 15 minutes to construct a HashMap<IdChain, IdChain> using the current hashCode implementation, but only takes a few seconds after changing to Arrays.hashCode().

[chain.json.tar.gz](https://github.com/user-attachments/files/16014242/chain.json.tar.gz)

Signed-off-by: gengjun-git <gengjun@starrocks.com>
(cherry picked from commit d6bccdb)
mergify bot pushed a commit that referenced this pull request Jun 28, 2024
@gengjun-git @mergify
[Enhancement] Optimize IdChain hash code implement (#47599)
eebd882 
The current implement of hashCode is easy to cause conflict. The data in the attachment takes 15 minutes to construct a HashMap<IdChain, IdChain> using the current hashCode implementation, but only takes a few seconds after changing to Arrays.hashCode().

[chain.json.tar.gz](https://github.com/user-attachments/files/16014242/chain.json.tar.gz)

Signed-off-by: gengjun-git <gengjun@starrocks.com>
(cherry picked from commit d6bccdb)
@mergify mergify bot mentioned this pull request Jun 28, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Jun 28, 2024
@gengjun-git @mergify
[Enhancement] Optimize IdChain hash code implement (#47599)
f6dc2fd 
The current implement of hashCode is easy to cause conflict. The data in the attachment takes 15 minutes to construct a HashMap<IdChain, IdChain> using the current hashCode implementation, but only takes a few seconds after changing to Arrays.hashCode().

[chain.json.tar.gz](https://github.com/user-attachments/files/16014242/chain.json.tar.gz)

Signed-off-by: gengjun-git <gengjun@starrocks.com>
(cherry picked from commit d6bccdb)
This was referenced Jun 28, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request Jun 28, 2024
@gengjun-git @mergify
[Enhancement] Optimize IdChain hash code implement (#47599)
6b2d908 
The current implement of hashCode is easy to cause conflict. The data in the attachment takes 15 minutes to construct a HashMap<IdChain, IdChain> using the current hashCode implementation, but only takes a few seconds after changing to Arrays.hashCode().

[chain.json.tar.gz](https://github.com/user-attachments/files/16014242/chain.json.tar.gz)

Signed-off-by: gengjun-git <gengjun@starrocks.com>
(cherry picked from commit d6bccdb)
@mergify mergify bot mentioned this pull request Jun 28, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Jun 28, 2024
@gengjun-git @mergify
[Enhancement] Optimize IdChain hash code implement (#47599)
6ae70b0 
The current implement of hashCode is easy to cause conflict. The data in the attachment takes 15 minutes to construct a HashMap<IdChain, IdChain> using the current hashCode implementation, but only takes a few seconds after changing to Arrays.hashCode().

[chain.json.tar.gz](https://github.com/user-attachments/files/16014242/chain.json.tar.gz)

Signed-off-by: gengjun-git <gengjun@starrocks.com>
(cherry picked from commit d6bccdb)
@mergify mergify bot mentioned this pull request Jun 28, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Jun 28, 2024
@mergify @gengjun-git
[Enhancement] Optimize IdChain hash code implement (backport #47599) (#…
0575fd4 
…47614)

Co-authored-by: gengjun-git <gengjun@starrocks.com>
wanpengfei-git pushed a commit that referenced this pull request Jun 28, 2024
@mergify @gengjun-git
[Enhancement] Optimize IdChain hash code implement (backport #47599) (#…
be8f7bd 
…47611)

Co-authored-by: gengjun-git <gengjun@starrocks.com>
wanpengfei-git pushed a commit that referenced this pull request Jun 28, 2024
@mergify @gengjun-git
[Enhancement] Optimize IdChain hash code implement (backport #47599) (#…
8e71704 
…47610)

Co-authored-by: gengjun-git <gengjun@starrocks.com>
wanpengfei-git pushed a commit that referenced this pull request Jun 28, 2024
@mergify @gengjun-git
[Enhancement] Optimize IdChain hash code implement (backport #47599) (#…
385da7e 
…47612)

Co-authored-by: gengjun-git <gengjun@starrocks.com>
wanpengfei-git pushed a commit that referenced this pull request Jun 28, 2024
@mergify @gengjun-git
[Enhancement] Optimize IdChain hash code implement (backport #47599) (#…
079a7fa 
…47613)

Co-authored-by: gengjun-git <gengjun@starrocks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshangyiming nshangyiming nshangyiming approved these changes

@imay imay imay approved these changes

Assignees

@gengjun-git gengjun-git

Labels
2.5-merged 3.0-merged 3.1-merged 3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gengjun-git @imay @nshangyiming