Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Support force cancel refresh materialized view & optimize some task run strategies (backport #46131) #47586

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 27, 2024

Why I'm doing:

  • Little bugs in mv refreshing.

What I'm doing:

  • Support force cancel refresh materialized view which can ensure the running task run can be removed from running queue to avoid occupying resources too long.
  • Add Config. enable_mv_refresh_sync_refresh_mergeable to support merge sync refresh mv task;
  • Add Config. max_mv_task_run_meta_message_values_length to limit the mv task run extra message's size;
  • Make ENABLE_INSERT_STRICT and ENABLE_PROFILE configurage in mv refresh.
  • Change filterRows to long since be's type is int64_t and it may be overflow .

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #46131 done by [Mergify](https://mergify.com). ## Why I'm doing: - Little bugs in mv refreshing.

What I'm doing:

  • Support force cancel refresh materialized view which can ensure the running task run can be removed from running queue to avoid occupying resources too long.
  • Add Config. enable_mv_refresh_sync_refresh_mergeable to support merge sync refresh mv task;
  • Add Config. max_mv_task_run_meta_message_values_length to limit the mv task run extra message's size;
  • Make ENABLE_INSERT_STRICT and ENABLE_PROFILE configurage in mv refresh.
  • Change filterRows to long since be's type is int64_t and it may be overflow .

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…me task run strategies (#46131)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
(cherry picked from commit 02fb889)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/scheduler/PartitionBasedMvRefreshProcessor.java
@mergify mergify bot added the conflicts label Jun 27, 2024
Copy link
Contributor Author

mergify bot commented Jun 27, 2024

Cherry-pick of 02fb889 has failed:

On branch mergify/bp/branch-3.3/pr-46131
Your branch is up to date with 'origin/branch-3.3'.

You are currently cherry-picking commit 02fb8899f4.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/common/Config.java
	modified:   fe/fe-core/src/main/java/com/starrocks/connector/CatalogConnectorMetadata.java
	modified:   fe/fe-core/src/main/java/com/starrocks/connector/ConnectorMetadata.java
	modified:   fe/fe-core/src/main/java/com/starrocks/qe/DDLStmtExecutor.java
	modified:   fe/fe-core/src/main/java/com/starrocks/qe/StmtExecutor.java
	modified:   fe/fe-core/src/main/java/com/starrocks/scheduler/Constants.java
	modified:   fe/fe-core/src/main/java/com/starrocks/scheduler/ExecuteOption.java
	modified:   fe/fe-core/src/main/java/com/starrocks/scheduler/TaskManager.java
	modified:   fe/fe-core/src/main/java/com/starrocks/scheduler/TaskRunFIFOQueue.java
	modified:   fe/fe-core/src/main/java/com/starrocks/scheduler/TaskRunManager.java
	modified:   fe/fe-core/src/main/java/com/starrocks/scheduler/TaskRunScheduler.java
	modified:   fe/fe-core/src/main/java/com/starrocks/scheduler/persist/MVTaskRunExtraMessage.java
	modified:   fe/fe-core/src/main/java/com/starrocks/scheduler/persist/TaskRunStatus.java
	modified:   fe/fe-core/src/main/java/com/starrocks/server/LocalMetastore.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/ast/CancelRefreshMaterializedViewStmt.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MvUtils.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/parser/AstBuilder.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/parser/StarRocks.g4
	modified:   fe/fe-core/src/test/java/com/starrocks/alter/AlterTest.java
	modified:   fe/fe-core/src/test/java/com/starrocks/analysis/CancelRefreshMaterializedViewTest.java
	modified:   fe/fe-core/src/test/java/com/starrocks/connector/CatalogConnectorMetadataTest.java
	modified:   fe/fe-core/src/test/java/com/starrocks/scheduler/MockTaskRunProcessor.java
	modified:   fe/fe-core/src/test/java/com/starrocks/scheduler/TaskManagerTest.java
	new file:   fe/fe-core/src/test/java/com/starrocks/scheduler/persist/MVTaskRunExtraMessageTest.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/scheduler/PartitionBasedMvRefreshProcessor.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Jun 27, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-3.3/pr-46131 branch June 27, 2024 09:38
@LiShuMing LiShuMing restored the mergify/bp/branch-3.3/pr-46131 branch June 27, 2024 11:07
@LiShuMing LiShuMing reopened this Jun 27, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) June 27, 2024 11:07
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
Copy link

@wanpengfei-git wanpengfei-git merged commit 1d8967c into branch-3.3 Jun 27, 2024
28 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-46131 branch June 27, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants