Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UT] Fix the test case: test_iceberg_parallel_prepare_metadata #47224

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

trueeyu
Copy link
Contributor

@trueeyu trueeyu commented Jun 19, 2024

Why I'm doing:

The problem is introduced by #47190

AssertionError: False is not true : assert expect ICEBERG.processSplit.IcebergFilter is not found in plan, error msg is ((' 0ms|-- Total[1] 21ms',), (' 0ms|    -- Analyzer[1] 0',), (' 0ms|        -- AnalyzeDatabase[2] 0',), (' 0ms|        -- AnalyzeTemporaryTable[2] 0',), (' 0ms|        -- AnalyzeTable[2] 0',), (' 0ms|    -- Transformer[1] 0',), (' 1ms|    -- Optimizer[1] 19ms',), (' 1ms|        -- preprocessMvs[1] 0',), (' 1ms|            -- chooseCandidates[1] 0',), (' 1ms|            -- generateMvPlan[1] 0',), (' 1ms|            -- validateMv[1] 0',), (' 1ms|            -- mvWithView[1] 0',), (' 1ms|        -- RuleBaseOptimize[1] 17ms',), (' 2ms|            -- EXTERNAL.parallel_prepare_metadata[1] 15ms',), (' 4ms|                -- ICEBERG.prepareTablesNum[2] 0',), (" 4ms|                -- ICEBERG.processSplit.Filter{databaseName='ice_db_b8b43ce035024a1e9deb4540bf0fbf6e', tableName='ice_tbl_b8b43ce035024a1e9deb4540bf0fbf6e', snapshotId=5413665458947157420, predicate=2: col_int = 1}[1] 3ms",), ("14ms|                -- ICEBERG.processSplit.Filter{databaseName='ice_db_b8b43ce035024a1e9deb4540bf0fbf6e', tableName='ice_tbl_b8b43ce035024a1e9deb4540bf0fbf6e', snapshotId=5413665458947157420, predicate=4: col_int = 2}[1] 3ms",), ('19ms|        -- CostBaseOptimize[1] 0',), ('19ms|        -- PhysicalRewrite[1] 0',), ('20ms|        -- PlanValidate[1] 0',), ('20ms|            -- InputDependenciesChecker[1] 0',), ('20ms|            -- TypeChecker[1] 0',), ('20ms|            -- CTEUniqueChecker[1] 0',), ('20ms|            -- ColumnReuseChecker[1] 0',), ('20ms|    -- ExecPlanBuild[1] 1ms',), ('Tracer Cost: 77us',))
]]></failure><system-out><![CDATA[[case name]:  test_iceberg_parallel_prepare_metadata

ICEBERG.processSplit. has already stated that it is Iceberg, so there is no need to output the subsequent information.

What I'm doing:

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: trueeyu <lxhhust350@qq.com>
Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@trueeyu trueeyu merged commit 6f342cd into StarRocks:main Jun 19, 2024
44 of 45 checks passed
@stephen-shelby
Copy link
Contributor

@Mergifyio backport branch-3.3

Copy link
Contributor

mergify bot commented Jun 20, 2024

backport branch-3.3

✅ Backports have been created

@github-actions github-actions bot added the 3.3 label Jun 20, 2024
mergify bot pushed a commit that referenced this pull request Jun 20, 2024
Signed-off-by: trueeyu <lxhhust350@qq.com>
(cherry picked from commit 6f342cd)
wanpengfei-git pushed a commit that referenced this pull request Jun 21, 2024
happut pushed a commit to happut/starrocks that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants