Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Make default bucket num at least 16 when table is unpartitioned (backport #47005) #47105

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 17, 2024

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #47005 done by [Mergify](https://mergify.com). ## Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…titioned (#47005)

Signed-off-by: meegoo <meegoo.sr@gmail.com>
(cherry picked from commit 2176e83)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/analysis/CTASAutoTabletTest.java
Copy link
Contributor Author

mergify bot commented Jun 17, 2024

Cherry-pick of 2176e83 has failed:

On branch mergify/bp/branch-3.1/pr-47005
Your branch is up to date with 'origin/branch-3.1'.

You are currently cherry-picking commit 2176e83e28.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/CatalogUtils.java
	modified:   fe/fe-core/src/main/java/com/starrocks/common/FeConstants.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/test/java/com/starrocks/analysis/CTASAutoTabletTest.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Jun 17, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) June 17, 2024 08:36
@mergify mergify bot closed this Jun 17, 2024
auto-merge was automatically disabled June 17, 2024 08:36

Pull request was closed

Copy link
Contributor Author

mergify bot commented Jun 17, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-3.1/pr-47005 branch June 17, 2024 08:37
@meegoo meegoo restored the mergify/bp/branch-3.1/pr-47005 branch June 17, 2024 08:39
@meegoo meegoo reopened this Jun 17, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) June 17, 2024 08:39
Signed-off-by: meegoo <meegoo.sr@gmail.com>
meegoo
meegoo previously approved these changes Jun 17, 2024
@meegoo meegoo disabled auto-merge June 17, 2024 08:40
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) June 17, 2024 08:40
Signed-off-by: meegoo <meegoo.sr@gmail.com>
@meegoo meegoo disabled auto-merge June 17, 2024 09:07
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) June 17, 2024 09:07
Copy link

@wanpengfei-git wanpengfei-git merged commit d9d3ed7 into branch-3.1 Jun 17, 2024
29 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.1/pr-47005 branch June 17, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants