Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix NullPointerException in mv update meta for iceberg catalog #46155

Merged
merged 1 commit into from
May 29, 2024

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented May 23, 2024

Why I'm doing:

ERROR_MESSAGE: Refresh materialized view dwd_cf_infe_tplcore_t_product_fee_a_min failed after retrying 1 times(try-lock 0 times), error-msg : java.lang.NullPointerException
	at com.starrocks.connector.iceberg.IcebergMetadata.getPartitions(IcebergMetadata.java:332)
	at com.starrocks.server.MetadataMgr.getPartitions(MetadataMgr.java:390)
	at com.starrocks.scheduler.PartitionBasedMvRefreshProcessor.getSelectedPartitionInfos(PartitionBasedMvRefreshProcessor.java:1747)
	at com.starrocks.scheduler.PartitionBasedMvRefreshProcessor.getSelectedPartitionInfosOfExternalTable(PartitionBasedMvRefreshProcessor.java:1725)
	at com.starrocks.scheduler.PartitionBasedMvRefreshProcessor.updateMeta(PartitionBasedMvRefreshProcessor.java:638)
	at com.starrocks.scheduler.PartitionBasedMvRefreshProcessor.doRefreshMaterializedView(PartitionBasedMvRefreshProcessor.java:377)
	at com.starrocks.scheduler.PartitionBasedMvRefreshProcessor.doRefreshMaterializedViewWithRetry(PartitionBasedMvRefreshProcessor.java:304)
	at com.starrocks.scheduler.PartitionBasedMvRefreshProcessor.doMvRefresh(PartitionBasedMvRefreshProcessor.java:255)
	at com.starrocks.scheduler.PartitionBasedMvRefreshProcessor.processTaskRun(PartitionBasedMvRefreshProcessor.java:194)
	at com.starrocks.scheduler.TaskRun.executeTaskRun(TaskRun.java:216)
	at com.starrocks.scheduler.TaskRunExecutor.lambda$executeTaskRun$0(TaskRunExecutor.java:53)
	at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1604)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:750)

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
@LiShuMing LiShuMing requested a review from a team as a code owner May 23, 2024 11:57
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

[FE Incremental Coverage Report]

fail : 3 / 6 (50.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/iceberg/IcebergMetadata.java 3 6 50.00% [389, 390, 391]

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@LiShuMing LiShuMing enabled auto-merge (squash) May 28, 2024 09:29
@kangkaisen kangkaisen disabled auto-merge May 29, 2024 05:57
@kangkaisen kangkaisen merged commit b0e3982 into StarRocks:main May 29, 2024
56 of 61 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label May 29, 2024
Copy link

@Mergifyio backport branch-3.2

Copy link

@Mergifyio backport branch-3.1

Copy link
Contributor

mergify bot commented May 29, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented May 29, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented May 29, 2024

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 29, 2024
…og (#46155)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
(cherry picked from commit b0e3982)
mergify bot pushed a commit that referenced this pull request May 29, 2024
…og (#46155)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
(cherry picked from commit b0e3982)
mergify bot pushed a commit that referenced this pull request May 29, 2024
…og (#46155)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
(cherry picked from commit b0e3982)
wanpengfei-git pushed a commit that referenced this pull request May 29, 2024
…og (backport #46155) (#46398)

Co-authored-by: shuming.li <ming.moriarty@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request May 29, 2024
…og (backport #46155) (#46397)

Co-authored-by: shuming.li <ming.moriarty@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request Jun 1, 2024
…og (backport #46155) (#46395)

Co-authored-by: shuming.li <ming.moriarty@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MV] update meta failed for iceberg catalog
3 participants