Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix schemachange failed caused by storage migration #45517

Merged
merged 1 commit into from
May 13, 2024
Merged

[BugFix] Fix schemachange failed caused by storage migration #45517

merged 1 commit into from
May 13, 2024

Conversation

decster
Copy link
Contributor

@decster decster commented May 13, 2024

Why I'm doing:

Schemachange will fail if tablet was migrated

What I'm doing:

When doing migration, check if tablet is in schemachange process, if so abort migration.

Fixes #45384

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@decster decster requested a review from a team as a code owner May 13, 2024 04:31
@decster decster force-pushed the fix-migration-schemachange branch from 46e5194 to 5a8aa3b Compare May 13, 2024 07:22
@decster
[BugFix] Fix schemachange failed caused by storage migration
e1f1b1a 
Signed-off-by: Binglin Chang <decstery@gmail.com>
@decster decster force-pushed the fix-migration-schemachange branch from 5a8aa3b to e1f1b1a Compare May 13, 2024 08:17
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/task/engine_storage_migration_task.cpp 4 4 100.00% []

@decster decster merged commit 97fd498 into StarRocks:main May 13, 2024
46 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label May 13, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@mergify Mergify
Copy link
Contributor

mergify bot commented May 13, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented May 13, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented May 13, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented May 13, 2024 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented May 13, 2024 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 13, 2024
@decster @mergify
[BugFix] Fix schemachange failed caused by storage migration (#45517)
a07eb1f 
Signed-off-by: Binglin Chang <decstery@gmail.com>
(cherry picked from commit 97fd498)
mergify bot pushed a commit that referenced this pull request May 13, 2024
@decster @mergify
[BugFix] Fix schemachange failed caused by storage migration (#45517)
d877053 
Signed-off-by: Binglin Chang <decstery@gmail.com>
(cherry picked from commit 97fd498)

# Conflicts:
#	be/test/storage/task/engine_storage_migration_task_test.cpp
mergify bot pushed a commit that referenced this pull request May 13, 2024
@decster @mergify
[BugFix] Fix schemachange failed caused by storage migration (#45517)
fbc11f9 
Signed-off-by: Binglin Chang <decstery@gmail.com>
(cherry picked from commit 97fd498)
This was referenced May 13, 2024
Merged
Merged
Merged
mergify bot pushed a commit that referenced this pull request May 13, 2024
@decster @mergify
[BugFix] Fix schemachange failed caused by storage migration (#45517)
0c2b0f6 
Signed-off-by: Binglin Chang <decstery@gmail.com>
(cherry picked from commit 97fd498)

# Conflicts:
#	be/test/storage/task/engine_storage_migration_task_test.cpp
mergify bot pushed a commit that referenced this pull request May 13, 2024
@decster @mergify
[BugFix] Fix schemachange failed caused by storage migration (#45517)
0431995 
Signed-off-by: Binglin Chang <decstery@gmail.com>
(cherry picked from commit 97fd498)

# Conflicts:
#	be/test/storage/task/engine_storage_migration_task_test.cpp
This was referenced May 13, 2024
Merged
Merged
wanpengfei-git pushed a commit that referenced this pull request May 13, 2024
@mergify @decster
[BugFix] Fix schemachange failed caused by storage migration (backport …
2157ca5 
…#45517) (#45561)

Co-authored-by: Binglin Chang <decstery@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request May 13, 2024
@mergify @decster
[BugFix] Fix schemachange failed caused by storage migration (backport …
7cd9d82 
…#45517) (#45562)

Co-authored-by: Binglin Chang <decstery@gmail.com>
decster added a commit that referenced this pull request May 13, 2024
@decster
[BugFix] Fix schemachange failed caused by storage migration (#45517)
2d17615 
Signed-off-by: Binglin Chang <decstery@gmail.com>
(cherry picked from commit 97fd498)
decster added a commit that referenced this pull request May 13, 2024
@decster
[BugFix] Fix schemachange failed caused by storage migration (#45517)
55b7eee 
Signed-off-by: Binglin Chang <decstery@gmail.com>
(cherry picked from commit 97fd498)
decster added a commit that referenced this pull request May 13, 2024
@decster
[BugFix] Fix schemachange failed caused by storage migration (#45517)
f414544 
Signed-off-by: Binglin Chang <decstery@gmail.com>
(cherry picked from commit 97fd498)
wanpengfei-git pushed a commit that referenced this pull request May 13, 2024
@mergify @decster
[BugFix] Fix schemachange failed caused by storage migration (backport …
1f3f712 
…#45517) (#45563)

Co-authored-by: Binglin Chang <decstery@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request May 13, 2024
@mergify @decster
[BugFix] Fix schemachange failed caused by storage migration (backport …
e5dd0de 
…#45517) (#45564)

Co-authored-by: Binglin Chang <decstery@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request May 13, 2024
@mergify @decster
[BugFix] Fix schemachange failed caused by storage migration (backport …
c0ee7bd 
…#45517) (#45565)

Co-authored-by: Binglin Chang <decstery@gmail.com>
node pushed a commit to vivo/starrocks that referenced this pull request May 17, 2024
@decster @node
[BugFix] Fix schemachange failed caused by storage migration (StarRoc…
a29d46c 
…ks#45517)

Signed-off-by: Binglin Chang <decstery@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevev sevev sevev approved these changes

@wyb wyb wyb approved these changes

Assignees

@decster decster

Labels
2.5-merged 3.0-merged 3.1-merged 3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SchemaChange failed because of storage migration
3 participants
@decster @wyb @sevev