Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix graceful exit crash when query iceberg eq-delete parquet file #43707

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

stephen-shelby
Copy link
Contributor

@stephen-shelby stephen-shelby commented Apr 8, 2024

Why I'm doing:

What I'm doing:

Fixes #issue
https://github.com/StarRocks/StarRocksTest/issues/6850

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

… file

Signed-off-by: stephen <stephen5217@163.com>
@stephen-shelby stephen-shelby requested a review from a team as a code owner April 8, 2024 04:25
Copy link

github-actions bot commented Apr 8, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Apr 8, 2024

[BE Incremental Coverage Report]

pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/iceberg/iceberg_delete_builder.cpp 1 1 100.00% []

@stephen-shelby stephen-shelby merged commit a5b68ef into StarRocks:main Apr 9, 2024
64 of 68 checks passed
Copy link

github-actions bot commented Apr 9, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Apr 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Apr 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

@Mergifyio backport branch-3.1

Copy link
Contributor

mergify bot commented Apr 9, 2024

backport branch-3.3

✅ Backports have been created

@github-actions github-actions bot removed the 3.1 label Apr 9, 2024
Copy link
Contributor

mergify bot commented Apr 9, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Apr 9, 2024

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 9, 2024
… file (#43707)

Signed-off-by: stephen <stephen5217@163.com>
(cherry picked from commit a5b68ef)
mergify bot pushed a commit that referenced this pull request Apr 9, 2024
… file (#43707)

Signed-off-by: stephen <stephen5217@163.com>
(cherry picked from commit a5b68ef)
mergify bot pushed a commit that referenced this pull request Apr 9, 2024
… file (#43707)

Signed-off-by: stephen <stephen5217@163.com>
(cherry picked from commit a5b68ef)

# Conflicts:
#	be/src/exec/iceberg/iceberg_delete_builder.cpp
wanpengfei-git pushed a commit that referenced this pull request Apr 9, 2024
… file (backport #43707) (#43757)

Co-authored-by: stephen <91597003+stephen-shelby@users.noreply.github.com>
wanpengfei-git pushed a commit that referenced this pull request Apr 9, 2024
… file (backport #43707) (#43756)

Co-authored-by: stephen <91597003+stephen-shelby@users.noreply.github.com>
stephen-shelby added a commit that referenced this pull request Apr 9, 2024
… file (backport #43707) (#43771)

Signed-off-by: stephen <stephen5217@163.com>
@stephen-shelby stephen-shelby deleted the fix_parquet_asan branch May 16, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants