Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]aggregation pipeline shared limit #42449

Merged
merged 1 commit into from
Apr 7, 2024
Merged

[Enhancement]aggregation pipeline shared limit #42449

merged 1 commit into from
Apr 7, 2024

Conversation

zombee0
Copy link
Contributor

@zombee0 zombee0 commented Mar 11, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@zombee0 zombee0 requested review from a team as code owners March 11, 2024 12:53
@zombee0 zombee0 changed the title [WIP][Enhancement]aggregation runtime limit [Enhancement]aggregation runtime limit Mar 22, 2024
@zombee0 zombee0 force-pushed the agg_rt_limit branch 4 times, most recently from a8dac28 to c9353d2 Compare March 27, 2024 12:36
@zombee0 zombee0 changed the title [Enhancement]aggregation runtime limit [Enhancement]aggregation pipeline shared limit Mar 29, 2024
@zombee0
[Enhancement]aggregation runtime limit
1e81265 
Signed-off-by: zombee0 <ewang2027@gmail.com>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2024

[FE Incremental Coverage Report]

✅ pass : 3 / 3 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/SessionVariable.java 2 2 100.00% []
🔵 com/starrocks/planner/AggregationNode.java 1 1 100.00% []

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2024

[BE Incremental Coverage Report]

✅ pass : 40 / 41 (97.56%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/pipeline/aggregate/aggregate_blocking_sink_operator.cpp 2 3 66.67% [133]
🔵 be/src/exec/pipeline/aggregate/aggregate_distinct_blocking_sink_operator.cpp 5 5 100.00% []
🔵 be/src/exec/aggregator.cpp 17 17 100.00% []
🔵 be/src/exec/pipeline/aggregate/spillable_aggregate_blocking_sink_operator.cpp 2 2 100.00% []
🔵 be/src/exec/pipeline/aggregate/aggregate_blocking_sink_operator.h 3 3 100.00% []
🔵 be/src/exec/pipeline/aggregate/aggregate_distinct_blocking_sink_operator.h 5 5 100.00% []
🔵 be/src/exec/aggregator.h 4 4 100.00% []
🔵 be/src/exec/pipeline/aggregate/spillable_aggregate_distinct_blocking_operator.cpp 2 2 100.00% []

@Seaven Seaven merged commit f07cf05 into StarRocks:main Apr 7, 2024
58 of 61 checks passed
@zombee0
Copy link
Contributor Author

zombee0 commented Apr 12, 2024

https://github.com/Mergifyio backport branch-3.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 12, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 12, 2024
@zombee0 @mergify
[Enhancement]aggregation pipeline shared limit (#42449)
7a6c372 
Signed-off-by: zombee0 <ewang2027@gmail.com>
(cherry picked from commit f07cf05)

# Conflicts:
#	be/src/exec/pipeline/aggregate/aggregate_distinct_blocking_sink_operator.cpp
#	fe/fe-core/src/main/java/com/starrocks/qe/SessionVariable.java
@mergify mergify bot mentioned this pull request Apr 12, 2024
Closed
41 tasks
Youngwb pushed a commit that referenced this pull request Apr 12, 2024
@zombee0
[Enhancement]aggregation runtime limit (backport #42449) (#43968)
2c553fe 
Signed-off-by: zombee0 <ewang2027@gmail.com>
@zombee0
Copy link
Contributor Author

zombee0 commented Apr 19, 2024

https://github.com/Mergifyio backport branch-3.3

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 19, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 19, 2024
@zombee0 @mergify
[Enhancement]aggregation pipeline shared limit (#42449)
e04c2a9 
Signed-off-by: zombee0 <ewang2027@gmail.com>
(cherry picked from commit f07cf05)
@mergify mergify bot mentioned this pull request Apr 19, 2024
Merged
41 tasks
wanpengfei-git pushed a commit that referenced this pull request Apr 22, 2024
@mergify @zombee0
[Enhancement]aggregation pipeline shared limit (backport #42449) (#44414
011e8c9 
)

Co-authored-by: zombee0 <ewang2027@gmail.com>
@zombee0 zombee0 mentioned this pull request Apr 26, 2024
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@satanson satanson satanson approved these changes

@Seaven Seaven Seaven approved these changes

@DorianZheng DorianZheng DorianZheng approved these changes

@stdpain stdpain stdpain approved these changes

Assignees

@zombee0 zombee0

Labels
3.2-merged 3.3-merged PROTO-REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zombee0 @satanson @Seaven @DorianZheng @stdpain