Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Scale Backends for connector sink when writing static partition tables #41564

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+243 −25
Open

[Enhancement] Scale Backends for connector sink when writing static partition tables #41564

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c45b6fd
do global shuffle
mxdzs0612 Jan 15, 2024
280a7f3
add coverage
mxdzs0612 Mar 5, 2024
20ec4da
fix
mxdzs0612 Mar 5, 2024
e1906cb
rebase
mxdzs0612 Mar 6, 2024
9898292
test
mxdzs0612 Mar 6, 2024
fb6090f
test
mxdzs0612 Mar 6, 2024
4ceced3
add cover
mxdzs0612 Mar 6, 2024
e6187c9
add cover2
mxdzs0612 Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rebase 
Signed-off-by: Jiao Mingye <mxdzs0612@gmail.com>
  • Loading branch information
@mxdzs0612
mxdzs0612 committed Mar 7, 2024
commit e1906cbba7b3bbac9862031be00905b7950be06e
5 changes: 4 additions & 1 deletion be/test/exec/pipeline/exchange_sink_operator_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ class ExchangeSinkOperatorTest : public testing::Test {
_request.query_options.__set_connector_sink_shuffle_buffer_size_mb(32);
auto rs = std::make_unique<RuntimeState>(_request.params.query_id, _request.params.fragment_instance_id,
_request.query_options, _request.query_globals, _exec_env);
ASSERT_EQ(rs->query_options().connector_sink_shuffle_buffer_size_mb, 32);

rs->set_func_version(0);
_fragment_context->set_runtime_state(std::move(rs));
_runtime_state = _fragment_context->runtime_state();
Expand Down Expand Up @@ -92,7 +94,8 @@ TEST_F(ExchangeSinkOperatorTest, test_push_random_scale) {
std::vector<int32_t> output_columns;
// auto mock_sink_buffer = std::make_shared<MockSinkBuffer>(_fragment_context, destinations, false);
auto mock_sink_buffer = std::make_shared<SinkBuffer>(_fragment_context, destinations, false);
ASSERT_EQ(mock_sink_buffer->connector_sink_need_scaling(0, 0), true);
auto is_scaling = mock_sink_buffer->connector_sink_need_scaling(0, 0);
ASSERT_EQ(is_scaling, true);

PlanNodeId id = 2;
auto exchange_sink_operator_factory = std::make_shared<ExchangeSinkOperatorFactory>(
Expand Down