Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] call generate_ir according to is_compiable #41093

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

fzhedu
Copy link
Contributor

@fzhedu fzhedu commented Feb 18, 2024

Why I'm doing:

call generate_ir_imp directly even it isn't compilable, would generate wrong ir.

What I'm doing:

call generate_ir_imp according to whether the expr is compiable.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: Zhuhe Fang <fzhedu@gmail.com>
@fzhedu fzhedu requested a review from a team as a code owner February 18, 2024 13:34
@mergify mergify bot assigned fzhedu Feb 18, 2024
Signed-off-by: Zhuhe Fang <fzhedu@gmail.com>
Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

fail : 18 / 24 (75.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exprs/binary_predicate.cpp 0 4 00.00% [123, 124, 391, 392]
🔵 be/src/exprs/arithmetic_expr.cpp 7 9 77.78% [336, 337]
🔵 be/src/exprs/case_expr.cpp 5 5 100.00% []
🔵 be/src/exprs/cast_expr.cpp 1 1 100.00% []
🔵 be/src/exprs/expr.cpp 4 4 100.00% []
🔵 be/src/exprs/jit/jit_engine.cpp 1 1 100.00% []

@fzhedu fzhedu changed the title [BugFix] call generate_ir according to is_compiable [Refactor] call generate_ir according to is_compiable Feb 19, 2024
@fzhedu fzhedu enabled auto-merge (squash) February 19, 2024 04:09
@kangkaisen kangkaisen disabled auto-merge February 19, 2024 04:45
@kangkaisen kangkaisen merged commit dd4208e into StarRocks:main Feb 19, 2024
66 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants