Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] remove useless dcheck #41051

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Conversation

luohaha
Copy link
Contributor

@luohaha luohaha commented Feb 17, 2024

Why I'm doing:

This is an unnecessary DCHECK and we can safely delete it.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: luohaha <18810541851@163.com>
@luohaha luohaha requested a review from a team as a code owner February 17, 2024 01:59
@github-actions github-actions bot added the 3.2 label Feb 17, 2024
Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@luohaha luohaha enabled auto-merge (squash) February 17, 2024 03:20
@luohaha luohaha merged commit c8c8161 into StarRocks:main Feb 17, 2024
42 checks passed
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Feb 17, 2024
Copy link
Contributor

mergify bot commented Feb 17, 2024

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 17, 2024
Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit c8c8161)
wanpengfei-git pushed a commit that referenced this pull request Feb 17, 2024
Co-authored-by: Yixin Luo <18810541851@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants