Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix NPE when cte forced inlined #40550

Merged
merged 2 commits into from
Feb 1, 2024
Merged

[BugFix] Fix NPE when cte forced inlined #40550

merged 2 commits into from
Feb 1, 2024

Conversation

liuyehcf
Copy link
Contributor

@liuyehcf liuyehcf commented Feb 1, 2024 •
edited
Loading

What I'm doing:

Introduced by #35000
Fix NPE when cte is forced inlined due to exceeding the cteMaxLimit(10)

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@liuyehcf
[BugFix] Fix NPE when cte forced inlined
7d9091f 
Signed-off-by: liuyehcf <1559500551@qq.com>
@liuyehcf liuyehcf requested a review from a team as a code owner February 1, 2024 08:21
@liuyehcf
update 1
fe14972 
Signed-off-by: liuyehcf <1559500551@qq.com>
@liuyehcf liuyehcf enabled auto-merge (squash) February 1, 2024 08:30
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

[FE Incremental Coverage Report]

✅ pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/transformer/RelationTransformer.java 2 2 100.00% []

@liuyehcf liuyehcf merged commit 4ff80a2 into StarRocks:main Feb 1, 2024
44 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

@Mergifyio backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 1, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 1, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 1, 2024
@liuyehcf @mergify
[BugFix] Fix NPE when cte forced inlined (#40550)
57a00c0 
Signed-off-by: liuyehcf <1559500551@qq.com>
(cherry picked from commit 4ff80a2)
mergify bot pushed a commit that referenced this pull request Feb 1, 2024
@liuyehcf @mergify
[BugFix] Fix NPE when cte forced inlined (#40550)
87e04b1 
Signed-off-by: liuyehcf <1559500551@qq.com>
(cherry picked from commit 4ff80a2)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/load/LoadJobWithWarehouse.java
This was referenced Feb 1, 2024
Merged
Merged
wanpengfei-git pushed a commit that referenced this pull request Feb 5, 2024
@mergify @liuyehcf
[BugFix] Fix NPE when cte forced inlined (backport #40550) (#40565)
185ab63 
Signed-off-by: liuyehcf <1559500551@qq.com>
Co-authored-by: liuyehcf <1559500551@qq.com>
wanpengfei-git pushed a commit that referenced this pull request Feb 10, 2024
@mergify @liuyehcf
[BugFix] Fix NPE when cte forced inlined (backport #40550) (#40564)
db9a300 
Co-authored-by: liuyehcf <1559500551@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seaven Seaven Seaven approved these changes

@kangkaisen kangkaisen kangkaisen approved these changes

Assignees

@liuyehcf liuyehcf

Labels
3.1-merged 3.2-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liuyehcf @Seaven @kangkaisen