[Enhancement] Make error message more clear of table function #39791
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zaorang Yang <zaorangy@gmail.com>
|
jaogoy
requested changes
Jan 23, 2024
| @@ -236,7 +236,8 @@ private void parseFiles() throws DdlException { | |||
| } | |||
| } catch (UserException e) { | |||
| LOG.error("parse files error", e); | |||
| throw new DdlException("failed to parse files", e); | |||
| String errorMsg = "failed to parse files. You may give a wrong url, please check it. " + path; | |||
There was a problem hiding this comment.
- Put the error message in ErrorCode.java file.
- "Failed to parse the path: ${path}. The URL scheme (${scheme}) in the path is not supported."
I'm curious why do you put the testing code in the src dir?
[FE Incremental Coverage Report]✅ pass : 4 / 4 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
If user set a wrong path URL, FE will complain like below. This is very misleading.
What I'm doing:
Fix it. The error message will be like below:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: