[Refactor] Refactor BaseTableInfo to be more clear #39546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
fe/fe-core/src/main/java/com/starrocks/catalog/BTInfoHelper.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/persist/BaseTableInfo.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/catalog/MaterializedView.java
Outdated
Show resolved
Hide resolved
LiShuMing
force-pushed
the
fix/main/refactor_base_table_infos.v1
branch
from
83a0e71 to
88fa5df
Compare
LiShuMing
changed the title
LiShuMing
force-pushed
the
fix/main/refactor_base_table_infos.v1
branch
from
d32ddd8 to
ba4be98
Compare
murphyatwork
previously approved these changes
Jan 30, 2024
| * because this method may return null if base table has already dropped or schema changed. | ||
| * </p> | ||
| * @return {@link Table} if BaseTableInfo is health otherwise null will be returned. | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
when to make this api private?
There was a problem hiding this comment.
later... because this will change too much codes.
nshangyiming
previously approved these changes
Jan 30, 2024
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
LiShuMing
dismissed stale reviews from nshangyiming and murphyatwork
via
0ab9b9e
LiShuMing
force-pushed
the
fix/main/refactor_base_table_infos.v1
branch
from
ba4be98 to
0ab9b9e
Compare
|
[FE Incremental Coverage Report]✅ pass : 60 / 63 (95.24%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
murphyatwork
approved these changes
Feb 2, 2024
ABingHuang
reviewed
Feb 2, 2024
fe/fe-core/src/main/java/com/starrocks/catalog/ForeignKeyConstraint.java
Show resolved
Hide resolved
ABingHuang
approved these changes
Feb 2, 2024
Seaven
approved these changes
Feb 2, 2024
nshangyiming
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
BaseTableInfois meta data and should not contain much util functions.What I'm doing:
BaseTableInfoand add more checks.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: