[BugFix] fix left outer join to inner join bug and string not equal rewrite bug #39331

ABingHuang · 2024-01-17T12:35:07Z

Why I'm doing:
mv with string not equal predicate rewrite failed because converting left outer join to inner join failed.

What I'm doing:
Fix it by:

fix converting left outer join to inner join bug
fix query with string not equal predicate rewrite failed bug.

Fixes #39330

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

fe/fe-core/src/main/java/com/starrocks/sql/optimizer/OptimizerContext.java

fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/JoinPredicatePushdown.java

...java/com/starrocks/sql/optimizer/rule/transformation/materialization/PredicateExtractor.java

fe/fe-core/src/main/java/com/starrocks/sql/optimizer/OptimizerContext.java

Signed-off-by: ABingHuang <codekhuang@163.com>

sonarqubecloud · 2024-01-31T02:56:07Z

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

8 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-01-31T06:38:15Z

[FE Incremental Coverage Report]

✅ pass : 38 / 38 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/sql/optimizer/Optimizer.java	2	2	100.00%	[]
🔵	com/starrocks/sql/optimizer/rule/transformation/materialization/PredicateExtractor.java	5	5	100.00%	[]
🔵	com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateJoinRule.java	1	1	100.00%	[]
🔵	com/starrocks/sql/optimizer/rule/transformation/materialization/MaterializedViewRewriter.java	2	2	100.00%	[]
🔵	com/starrocks/sql/optimizer/OptimizerContext.java	6	6	100.00%	[]
🔵	com/starrocks/sql/optimizer/rewrite/JoinPredicatePushdown.java	21	21	100.00%	[]
🔵	com/starrocks/sql/optimizer/rule/transformation/PushDownJoinOnClauseRule.java	1	1	100.00%	[]

github-actions · 2024-01-31T06:41:31Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-01-31T06:57:35Z

@Mergifyio backport branch-3.2

github-actions · 2024-01-31T06:57:36Z

@Mergifyio backport branch-3.1

github-actions · 2024-01-31T06:57:38Z

@Mergifyio backport branch-3.0

mergify · 2024-01-31T06:57:38Z

backport branch-3.2

✅ Backports have been created

#40437 [BugFix] fix left outer join to inner join bug and string not equal rewrite bug (backport #39331) has been created for branch branch-3.2 but encountered conflicts

github-actions · 2024-01-31T06:57:39Z

@Mergifyio backport branch-2.5

mergify · 2024-01-31T06:57:40Z

backport branch-3.1

✅ Backports have been created

#40438 [BugFix] fix left outer join to inner join bug and string not equal rewrite bug (backport #39331) has been created for branch branch-3.1 but encountered conflicts

mergify · 2024-01-31T06:57:42Z

backport branch-3.0

✅ Backports have been created

#40439 [BugFix] fix left outer join to inner join bug and string not equal rewrite bug (backport #39331) has been created for branch branch-3.0 but encountered conflicts

mergify · 2024-01-31T06:57:44Z

backport branch-2.5

✅ Backports have been created

#40440 [BugFix] fix left outer join to inner join bug and string not equal rewrite bug (backport #39331) has been created for branch branch-2.5 but encountered conflicts

…ewrite bug (#39331) Signed-off-by: ABingHuang <codekhuang@163.com> (cherry picked from commit 37b8aa5) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/OptimizerContext.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorRewriter.java

…ewrite bug (#39331) Signed-off-by: ABingHuang <codekhuang@163.com> (cherry picked from commit 37b8aa5) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/OptimizerContext.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorRewriter.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/PredicateExtractor.java # fe/fe-core/src/test/java/com/starrocks/planner/MaterializedViewTest.java

…ewrite bug (#39331) Signed-off-by: ABingHuang <codekhuang@163.com> (cherry picked from commit 37b8aa5) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/OptimizerContext.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/JoinPredicatePushdown.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorRewriter.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/PushDownJoinOnClauseRule.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateJoinRule.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MaterializedViewRewriter.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/PredicateExtractor.java # fe/fe-core/src/test/java/com/starrocks/planner/MaterializedViewTest.java

…ewrite bug (#39331) Signed-off-by: ABingHuang <codekhuang@163.com> (cherry picked from commit 37b8aa5) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/OptimizerContext.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/JoinPredicatePushdown.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorRewriter.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/PushDownJoinOnClauseRule.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateJoinRule.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MaterializedViewRewriter.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/PredicateExtractor.java

…ewrite bug (StarRocks#39331) Signed-off-by: ABingHuang <codekhuang@163.com>

…ewrite bug for 2.5 (backport #39331) (#40687) Signed-off-by: ABingHuang <codekhuang@163.com>

…ewrite bug (StarRocks#39331) Signed-off-by: ABingHuang <codekhuang@163.com>

#41549) Signed-off-by: ABingHuang <codekhuang@163.com>

…ewrite bug (StarRocks#39331) Signed-off-by: ABingHuang <codekhuang@163.com>

…ort #41428) (#41703) Signed-off-by: ABingHuang <codekhuang@163.com>

ABingHuang requested a review from a team as a code owner January 17, 2024 12:35

ABingHuang enabled auto-merge (squash) January 17, 2024 12:35

github-actions bot added 3.2 3.1 3.0 2.5 labels Jan 17, 2024

mergify bot assigned ABingHuang Jan 17, 2024

starrocks-cr bot reviewed Jan 17, 2024

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/sql/optimizer/OptimizerContext.java Show resolved Hide resolved

starrocks-cr bot reviewed Jan 17, 2024

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/JoinPredicatePushdown.java Show resolved Hide resolved

starrocks-cr bot reviewed Jan 17, 2024

View reviewed changes

...java/com/starrocks/sql/optimizer/rule/transformation/materialization/PredicateExtractor.java Outdated Show resolved Hide resolved

murphyatwork previously approved these changes Jan 18, 2024

View reviewed changes

LiShuMing previously approved these changes Jan 19, 2024

View reviewed changes

Seaven reviewed Jan 19, 2024

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/sql/optimizer/OptimizerContext.java Show resolved Hide resolved

ABingHuang dismissed stale reviews from LiShuMing and murphyatwork via 7ff7984 January 30, 2024 12:25

ABingHuang force-pushed the issue/39330_optimize_join_predicate_pushdown branch from 7ff7984 to 0e44e59 Compare January 30, 2024 12:37

fix left outer join to inner join bug and string not equal rewrite bug

159409c

Signed-off-by: ABingHuang <codekhuang@163.com>

ABingHuang force-pushed the issue/39330_optimize_join_predicate_pushdown branch from 0e44e59 to 159409c Compare January 31, 2024 02:48

Seaven approved these changes Jan 31, 2024

View reviewed changes

LiShuMing approved these changes Jan 31, 2024

View reviewed changes

ABingHuang merged commit 37b8aa5 into StarRocks:main Jan 31, 2024
43 checks passed

github-actions bot removed 3.2 3.1 labels Jan 31, 2024

github-actions bot removed the 3.0 label Jan 31, 2024

github-actions bot removed the 2.5 label Jan 31, 2024

This was referenced Jan 31, 2024

[BugFix] fix left outer join to inner join bug and string not equal rewrite bug (backport #39331) #40437

Closed

[BugFix] fix left outer join to inner join bug and string not equal rewrite bug (backport #39331) #40438

Closed

mergify bot mentioned this pull request Jan 31, 2024

[BugFix] fix left outer join to inner join bug and string not equal rewrite bug (backport #39331) #40439

Closed

18 tasks

mergify bot mentioned this pull request Jan 31, 2024

[BugFix] fix left outer join to inner join bug and string not equal rewrite bug (backport #39331) #40440

Closed

18 tasks

ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Feb 4, 2024

[BugFix] fix left outer join to inner join bug and string not equal r…

3f1e2c2

…ewrite bug (StarRocks#39331) Signed-off-by: ABingHuang <codekhuang@163.com>

ABingHuang added a commit that referenced this pull request Feb 5, 2024

[BugFix] fix left outer join to inner join bug and string not equal r…

469275d

…ewrite bug for 2.5 (backport #39331) (#40687) Signed-off-by: ABingHuang <codekhuang@163.com>

github-actions bot added the 2.5-merged label Feb 5, 2024

ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Feb 23, 2024

[BugFix] fix left outer join to inner join bug and string not equal r…

61a3745

…ewrite bug (StarRocks#39331) Signed-off-by: ABingHuang <codekhuang@163.com>

ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Feb 23, 2024

[BugFix] fix left outer join to inner join bug and string not equal r…

e00205a

…ewrite bug (StarRocks#39331) Signed-off-by: ABingHuang <codekhuang@163.com>

ABingHuang added a commit that referenced this pull request Feb 23, 2024

[BugFix] Fix left outer join plan bug for 3.1 (backport #39331 #41428) (

01a4a9d

#41549) Signed-off-by: ABingHuang <codekhuang@163.com>

github-actions bot added the 3.1-merged label Feb 23, 2024

ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Feb 27, 2024

[BugFix] fix left outer join to inner join bug and string not equal r…

991e6c9

…ewrite bug (StarRocks#39331) Signed-off-by: ABingHuang <codekhuang@163.com>

ABingHuang added a commit that referenced this pull request Feb 27, 2024

[BugFix] Fix left outer join plan bug for 3.2 (backport #39331)(backp…

78e52f2

…ort #41428) (#41703) Signed-off-by: ABingHuang <codekhuang@163.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BugFix] fix left outer join to inner join bug and string not equal rewrite bug #39331

[BugFix] fix left outer join to inner join bug and string not equal rewrite bug #39331

ABingHuang commented Jan 17, 2024

sonarqubecloud bot commented Jan 31, 2024

github-actions bot commented Jan 31, 2024

github-actions bot commented Jan 31, 2024

github-actions bot commented Jan 31, 2024

github-actions bot commented Jan 31, 2024

github-actions bot commented Jan 31, 2024

mergify bot commented Jan 31, 2024 •

edited

Loading

github-actions bot commented Jan 31, 2024

mergify bot commented Jan 31, 2024 •

edited

Loading

mergify bot commented Jan 31, 2024 •

edited

Loading

mergify bot commented Jan 31, 2024 •

edited

Loading

[BugFix] fix left outer join to inner join bug and string not equal rewrite bug #39331

[BugFix] fix left outer join to inner join bug and string not equal rewrite bug #39331

Conversation

ABingHuang commented Jan 17, 2024

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

sonarqubecloud bot commented Jan 31, 2024

Quality Gate passed

github-actions bot commented Jan 31, 2024

[FE Incremental Coverage Report]

file detail

github-actions bot commented Jan 31, 2024

[BE Incremental Coverage Report]

github-actions bot commented Jan 31, 2024

github-actions bot commented Jan 31, 2024

github-actions bot commented Jan 31, 2024

mergify bot commented Jan 31, 2024 • edited Loading

✅ Backports have been created

github-actions bot commented Jan 31, 2024

mergify bot commented Jan 31, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Jan 31, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Jan 31, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Jan 31, 2024 •

edited

Loading

mergify bot commented Jan 31, 2024 •

edited

Loading

mergify bot commented Jan 31, 2024 •

edited

Loading

mergify bot commented Jan 31, 2024 •

edited

Loading