Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Banned hive full acid table #39264

Merged
merged 1 commit into from
Jan 17, 2024
Merged

[BugFix] Banned hive full acid table #39264

merged 1 commit into from
Jan 17, 2024

Conversation

Smith-Cruise
Copy link
Contributor

@Smith-Cruise Smith-Cruise commented Jan 17, 2024 •
edited
Loading

Why I'm doing:
SR doesn't support full acid hive transactional tables, which will return wrong results.

What I'm doing:
Just ban it, and we will filter these not-supported tables.

Notice:
Hive has two types of transactional tables: one is insert_only table and the other is full acid table.

SR supports read insert_only transactional table but does not support full acid table. So banned full acid table is enough.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@Smith-Cruise
[BugFix] Banned hive full acid table
2e701ca 
Signed-off-by: Smith Cruise <chendingchao1@126.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 3 / 3 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/hive/HiveMetastore.java 3 3 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@Youngwb Youngwb merged commit a685c5f into StarRocks:main Jan 17, 2024
44 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Jan 17, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Jan 17, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@github-actions github-actions bot removed the 3.0 label Jan 17, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@github-actions github-actions bot removed the 2.5 label Jan 17, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2024 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2024 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 17, 2024
@Smith-Cruise @mergify
[BugFix] Banned hive full acid table (#39264)
f4b98fe 
Signed-off-by: Smith Cruise <chendingchao1@126.com>
(cherry picked from commit a685c5f)
@mergify mergify bot mentioned this pull request Jan 17, 2024
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Jan 17, 2024
@Smith-Cruise @mergify
[BugFix] Banned hive full acid table (#39264)
f6cbc8d 
Signed-off-by: Smith Cruise <chendingchao1@126.com>
(cherry picked from commit a685c5f)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/connector/hive/HiveMetastore.java
#	fe/fe-core/src/test/java/com/starrocks/connector/hive/CachingHiveMetastoreTest.java
#	fe/fe-core/src/test/java/com/starrocks/connector/hive/HiveMetastoreTest.java
mergify bot pushed a commit that referenced this pull request Jan 17, 2024
@Smith-Cruise @mergify
[BugFix] Banned hive full acid table (#39264)
4546c68 
Signed-off-by: Smith Cruise <chendingchao1@126.com>
(cherry picked from commit a685c5f)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/connector/hive/HiveMetastore.java
#	fe/fe-core/src/test/java/com/starrocks/connector/hive/CachingHiveMetastoreTest.java
#	fe/fe-core/src/test/java/com/starrocks/connector/hive/HiveMetastoreTest.java
This was referenced Jan 17, 2024
Closed
Closed
mergify bot pushed a commit that referenced this pull request Jan 17, 2024
@Smith-Cruise @mergify
[BugFix] Banned hive full acid table (#39264)
4bfeb4f 
Signed-off-by: Smith Cruise <chendingchao1@126.com>
(cherry picked from commit a685c5f)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/connector/hive/HiveMetastore.java
#	fe/fe-core/src/test/java/com/starrocks/connector/hive/CachingHiveMetastoreTest.java
#	fe/fe-core/src/test/java/com/starrocks/connector/hive/HiveMetastoreTest.java
@mergify mergify bot mentioned this pull request Jan 17, 2024
Closed
18 tasks
@Smith-Cruise Smith-Cruise deleted the ban-acid branch January 17, 2024 11:13
@Smith-Cruise Smith-Cruise mentioned this pull request Jan 17, 2024
Merged
23 tasks
wanpengfei-git pushed a commit that referenced this pull request Jan 18, 2024
@mergify @Smith-Cruise
[BugFix] Banned hive full acid table (backport #39264) (#39313)
840de49 
Co-authored-by: Smith Cruise <chendingchao1@126.com>
Youngwb pushed a commit that referenced this pull request Jan 18, 2024
@Smith-Cruise
[BugFix] Banned hive full acid table (backport #39264) (#39320)
96b0403 
Signed-off-by: Smith Cruise <chendingchao1@126.com>
Seaven pushed a commit to Seaven/starrocks that referenced this pull request Jan 30, 2024
@Smith-Cruise @Seaven
[BugFix] Banned hive full acid table (StarRocks#39264)
598570a 
Signed-off-by: Smith Cruise <chendingchao1@126.com>
Signed-off-by: Seaven <seaven_7@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youngwb Youngwb Youngwb approved these changes

@letian-jiang letian-jiang letian-jiang approved these changes

@stephen-shelby stephen-shelby stephen-shelby approved these changes

Assignees

@Smith-Cruise Smith-Cruise

Labels
2.5 3.1-merged 3.1 3.2-merged 3.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Smith-Cruise @Youngwb @letian-jiang @stephen-shelby