Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add more lock info in sys fe_locks #38973

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

wyb
Copy link
Contributor

@wyb wyb commented Jan 12, 2024

  1. change start_time type to DATETIME
  2. add hold_time_ms
mysql> select * from sys.fe_locks where lock_object = "tmp";
+-----------+-------------+-----------+---------------------+--------------+------------------------------------------------------------+---------+-------------------------------------------------------------------------------------------------+
| lock_type | lock_object | lock_mode | start_time          | hold_time_ms | thread_info                                                | granted | waiter_list                                                                                     |
+-----------+-------------+-----------+---------------------+--------------+------------------------------------------------------------+---------+-------------------------------------------------------------------------------------------------+
| DATABASE  | tmp         | EXCLUSIVE | 2024-01-12 14:23:09 |        66783 | {"threadId":683,"threadName":"starrocks-mysql-nio-pool-5"} |       1 | [{"threadId":133,"threadName":"COMPACTION_DISPATCH"},{"threadId":66,"threadName":"autovacuum"}] |
+-----------+-------------+-----------+---------------------+--------------+------------------------------------------------------------+---------+-------------------------------------------------------------------------------------------------+
1 row in set (0.01 sec)

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Copy link

@wyb wyb force-pushed the sys_fe_locks_more branch from 21d933c to f3a0764 Compare January 15, 2024 02:03
1. change start_time type to DATETIME
2. add hold_time_ms

Signed-off-by: wyb <wybb86@gmail.com>
@wyb wyb force-pushed the sys_fe_locks_more branch from f3a0764 to 8750a81 Compare January 15, 2024 18:01
Copy link

[FE Incremental Coverage Report]

pass : 7 / 7 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/system/sys/SysFeLocks.java 7 7 100.00% []

Copy link

[BE Incremental Coverage Report]

fail : 0 / 4 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/exec/schema_scanner/sys_fe_locks.cpp 0 4 00.00% [45, 57, 60, 62]

@wyb wyb merged commit 17b0a8d into StarRocks:main Jan 16, 2024
41 of 45 checks passed
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Jan 16, 2024
Copy link
Contributor

mergify bot commented Jan 16, 2024

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 16, 2024
Signed-off-by: wyb <wybb86@gmail.com>
(cherry picked from commit 17b0a8d)
wanpengfei-git pushed a commit that referenced this pull request Jan 16, 2024
wyb added a commit to wyb/starrocks that referenced this pull request Jan 16, 2024
wyb added a commit to wyb/starrocks that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants