[Enhancement] reduce tablet shard read lock holding time when calc persistent index compact score #38299
Access has been restricted
You have triggered a rate limit.
Please wait a few minutes before you try again;
in some cases this may take up to an hour.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
…rsistent index compact score Signed-off-by: luohaha <18810541851@163.com>
luohaha
force-pushed
the
fix-pk-index-compact-calc-score
branch
from
47c1831 to
e782047
Compare
chaoyli
approved these changes
Jan 3, 2024
decster
approved these changes
Jan 3, 2024
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]❌ fail : 0 / 10 (00.00%) file detail
|
trueeyu
approved these changes
Jan 3, 2024
|
@Mergifyio backport branch-3.2 |
|
@Mergifyio backport branch-3.1 |
|
@Mergifyio backport branch-3.0 |
|
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
18 tasks
Jay-ju
reviewed
Jan 3, 2024
| _update_manager->get_pindex_compaction_mgr()->schedule([&]() { | ||
| return StorageEngine::instance()->tablet_manager()->pick_tablets_to_do_pk_index_major_compaction(); | ||
| }); | ||
| if (config::enable_pindex_minor_compaction) { |
There was a problem hiding this comment.
why control major compact by minor switch ?
There was a problem hiding this comment.
Because if there is no minor compaction, we don't need to do major compaction.
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
When calc persistent index compact score, if pindex not exist in index cache, we will read persistent meta from rocksdb which can be very slow. We should't hold tablet shard read lock to do this, because it will affect tablet create and drop.
What I'm doing:
Remove persistent index compact score calculation from tablet shard read lock.
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: