Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] skip preload if memory exceed #38234

Merged
merged 1 commit into from
Jan 2, 2024
Merged

[Enhancement] skip preload if memory exceed #38234

merged 1 commit into from
Jan 2, 2024

Conversation

luohaha
Copy link
Contributor

@luohaha luohaha commented Jan 2, 2024

Why I'm doing:
We have preload update & compaction state when data loading & compaction finish to accelerate publish, but if update memory exceed, we should skip do preload.

What I'm doing:
skip preload if memory exceed

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@mergify mergify bot assigned luohaha Jan 2, 2024
@luohaha
[Enhancement] skip preload if memory exceed
d036c67 
Signed-off-by: luohaha <18810541851@163.com>
@luohaha luohaha force-pushed the improve-lake-pk-preload branch from a56b0f1 to d036c67 Compare January 2, 2024 07:39
@wyb wyb enabled auto-merge (squash) January 2, 2024 07:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2024

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@wyb wyb merged commit 932d859 into StarRocks:main Jan 2, 2024
43 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2024

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2024

@Mergifyio backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 2, 2024
@luohaha @mergify
[Enhancement] skip preload if memory exceed (#38234)
81da053 
Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit 932d859)
@mergify mergify bot mentioned this pull request Jan 2, 2024
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Jan 2, 2024
@luohaha @mergify
[Enhancement] skip preload if memory exceed (#38234)
a4708b5 
Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit 932d859)

# Conflicts:
#	be/src/storage/lake/update_manager.cpp
@mergify mergify bot mentioned this pull request Jan 2, 2024
Merged
18 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2024

[BE Incremental Coverage Report]

✅ pass : 3 / 3 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/storage/lake/update_manager.cpp 3 3 100.00% []

wanpengfei-git pushed a commit that referenced this pull request Jan 2, 2024
@mergify @luohaha
[Enhancement] skip preload if memory exceed (backport #38234) (#38248)
689ebb4 
Co-authored-by: Yixin Luo <18810541851@163.com>
wanpengfei-git pushed a commit that referenced this pull request Jan 2, 2024
@mergify @luohaha
[Enhancement] skip preload if memory exceed (backport #38234) (#38249)
79d7288 
Signed-off-by: Yixin Luo <18810541851@163.com>
Co-authored-by: Yixin Luo <18810541851@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TszKitLo40 TszKitLo40 TszKitLo40 approved these changes

@sduzh sduzh sduzh approved these changes

@wyb wyb wyb approved these changes

Assignees

@luohaha luohaha

Labels
3.1-merged 3.2-merged backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@luohaha @wyb @sduzh @TszKitLo40 @wangruin