-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Support querying Iceberg tables that have been REPLACE PARTITION FIELD #37452
Conversation
…PARTITION FIELD Signed-off-by: LPL <lipenglin@apache.org>
public static String getPartitionSourceName(Schema schema, PartitionField partition) { | ||
return schema.findColumnName(partition.sourceId()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you comment here to explain the difference from PartitionField.name() and elaborate on when to use which?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for comments!
* - https://iceberg.apache.org/spec/#partition-specs<br> | ||
* - https://iceberg.apache.org/spec/#partition-transforms | ||
*/ | ||
public static String getPartitionSourceName(Schema schema, PartitionField partition) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this function could put at IcebergTable, there is no need to be a static utils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
[FE Incremental Coverage Report]✅ pass : 5 / 5 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
* - https://iceberg.apache.org/spec/#partition-transforms | ||
*/ | ||
public String getPartitionSourceName(Schema schema, PartitionField partition) { | ||
return schema.findColumnName(partition.sourceId()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,We may refactor this part after fully supporting the transformed partition.
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
…PARTITION FIELD (StarRocks#37452) Signed-off-by: LPL <lipenglin@apache.org>
Why I'm doing:
What I'm doing:
Iceberg tables
field.name
may not necessarily bepartition-spec.field.name
foridentity Partition Transforms
,field.name
should be identified usingpartition-spec.field.source-id
inschema
.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: