Fix: set scan_ranges after preparing node #3738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangkaisen
approved these changes
Mar 1, 2022
Seaven
approved these changes
Mar 1, 2022
ZiheLiu
added a commit
to ZiheLiu/starrocks
that referenced
this pull request
Mar 1, 2022
4 tasks
ZiheLiu
added a commit
to ZiheLiu/starrocks
that referenced
this pull request
Mar 1, 2022
4 tasks
kangkaisen
pushed a commit
that referenced
this pull request
Mar 1, 2022
kangkaisen
pushed a commit
that referenced
this pull request
Mar 1, 2022
caneGuy
pushed a commit
to caneGuy/starrocks
that referenced
this pull request
Mar 28, 2023
jaogoy
pushed a commit
to jaogoy/starrocks
that referenced
this pull request
Nov 15, 2023
…Rocks#3873) (cherry picked from commit bdbe260) Co-authored-by: trueeyu <lxhhust350@qq.com>
jaogoy
pushed a commit
to jaogoy/starrocks
that referenced
this pull request
Nov 15, 2023
…Rocks#3874) (cherry picked from commit bdbe260) Co-authored-by: trueeyu <lxhhust350@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this：
Problem Summary(Required) ：
OlapScanNode::set_scan_rangesuses some variables init byOlapScanNode::preapre, so we must callpreparebeforeset_scan_ranges.The previous PR #3720 move
prepareafterset_scan_ranges, becauseOlapScanNode::prepare()callscapture_tablet_rowsets, which needs to be invoked afterset_scan_ranges.Therefore, we rearrange
preparebeforeset_scan_ranges, and callOlapScanNode::capture_tablet_rowsetin the last ofOlapScanNode::set_scan_ranges.