[WIP][Feature] Support count data size of db and table via /api/show_data #37183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: redscarf <hongweijin1993@gmail.com>
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
| return dbs.parallelStream() | ||
| .mapToLong(this::getDataSizeOfDatabase) | ||
| .sum(); | ||
| } | ||
| } |
There was a problem hiding this comment.
The most risky bug in this code is:
Inconsistent handling of concurrency which might lead to incorrect calculation of data size due to potential concurrent modification of fullNameToDb.
You can modify the code like this:
// Guard fullNameToDb with synchronized block or use a thread-safe approach when iterating over it
synchronized (fullNameToDb) {
// Access the fullNameToDb map within this block.
}
Secondary concerns that could be addressed but are not as severe include:
- Potential class cast exceptions if
tableis not an instance ofOlapTable. - Inefficiency from parallel streams may not always be beneficial depending on the size of data being processed. It could be counterproductive for small datasets.
|
[FE Incremental Coverage Report]✅ pass : 28 / 33 (84.85%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Jin-H
changed the title
Signed-off-by: redscarf <hongweijin1993@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Fixes #34477
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: