Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix delete flag lost in persistent index minor compact #36731

Merged
merged 2 commits into from
Dec 9, 2023
Merged

[BugFix] fix delete flag lost in persistent index minor compact #36731

merged 2 commits into from
Dec 9, 2023

Conversation

luohaha
Copy link
Contributor

@luohaha luohaha commented Dec 8, 2023

Why I'm doing:
When flush l0 file to l1 file, or advance compact multi tmp l1 files, we decide keep delete flag when l2 files exist. But it's no enough, because when old l1 exist, we still need to keep delete flag when flush and compaction.

What I'm doing:
keep delete flag when older l1 files exist.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@mergify mergify bot assigned luohaha Dec 8, 2023
@github-actions github-actions bot added the 2.5 label Dec 8, 2023
@luohaha luohaha force-pushed the fix-minor-compact-del branch from 15e1582 to d74d217 Compare December 8, 2023 23:08
@luohaha luohaha marked this pull request as ready for review December 8, 2023 23:09
@luohaha luohaha requested review from decster, sevev and chaoyli December 8, 2023 23:12
chaoyli
chaoyli previously approved these changes Dec 8, 2023
View reviewed changes
@luohaha
[BugFix] fix delete flag lost in persistent index minor compact
ef04dd3 
Signed-off-by: luohaha <18810541851@163.com>
@luohaha luohaha force-pushed the fix-minor-compact-del branch from d74d217 to ef04dd3 Compare December 9, 2023 00:09
@luohaha
fix clang format
3b4e66c 
Signed-off-by: luohaha <18810541851@163.com>
@luohaha luohaha enabled auto-merge (squash) December 9, 2023 00:56
@luohaha luohaha merged commit be4f6ff into StarRocks:main Dec 9, 2023
37 of 38 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2023

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Dec 9, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2023

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Dec 9, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2023

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Dec 9, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 9, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2023

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Dec 9, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 9, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 9, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 9, 2023 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 9, 2023
@luohaha @mergify
[BugFix] fix delete flag lost in persistent index minor compact (#36731)
d56ebdf 
Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit be4f6ff)
@mergify mergify bot mentioned this pull request Dec 9, 2023
Merged
mergify bot pushed a commit that referenced this pull request Dec 9, 2023
@luohaha @mergify
[BugFix] fix delete flag lost in persistent index minor compact (#36731)
a5290e1 
Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit be4f6ff)

# Conflicts:
#	be/src/storage/persistent_index.cpp
#	be/test/storage/persistent_index_test.cpp
@mergify mergify bot mentioned this pull request Dec 9, 2023
Merged
mergify bot pushed a commit that referenced this pull request Dec 9, 2023
@luohaha @mergify
[BugFix] fix delete flag lost in persistent index minor compact (#36731)
c2bd6ec 
Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit be4f6ff)

# Conflicts:
#	be/src/storage/persistent_index.cpp
#	be/test/storage/persistent_index_test.cpp
@mergify mergify bot mentioned this pull request Dec 9, 2023
Merged
mergify bot pushed a commit that referenced this pull request Dec 9, 2023
@luohaha @mergify
[BugFix] fix delete flag lost in persistent index minor compact (#36731)
442df98 
Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit be4f6ff)

# Conflicts:
#	be/src/storage/persistent_index.cpp
#	be/test/storage/persistent_index_test.cpp
@mergify mergify bot mentioned this pull request Dec 9, 2023
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2023

[FE Incremental Coverage Report]

✅ pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/iceberg/IcebergMetadata.java 1 1 100.00% []
🔵 com/starrocks/connector/iceberg/IcebergCatalog.java 1 1 100.00% []
🔵 com/starrocks/connector/iceberg/CachingIcebergCatalog.java 2 2 100.00% []

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2023

[BE Incremental Coverage Report]

✅ pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/storage/persistent_index.cpp 2 2 100.00% []

wanpengfei-git pushed a commit that referenced this pull request Dec 9, 2023
@mergify @luohaha
[BugFix] fix delete flag lost in persistent index minor compact (back…
77266dd 
…port #36731) (#36733)

Co-authored-by: Yixin Luo <18810541851@163.com>
wanpengfei-git pushed a commit that referenced this pull request Dec 9, 2023
@mergify @luohaha
[BugFix] fix delete flag lost in persistent index minor compact (back…
731875b 
…port #36731) (#36734)

Signed-off-by: Yixin Luo <18810541851@163.com>
Co-authored-by: Yixin Luo <18810541851@163.com>
wanpengfei-git pushed a commit that referenced this pull request Dec 9, 2023
@mergify @luohaha
[BugFix] fix delete flag lost in persistent index minor compact (back…
6a507c5 
…port #36731) (#36735)

Signed-off-by: Yixin Luo <18810541851@163.com>
Co-authored-by: Yixin Luo <18810541851@163.com>
wanpengfei-git pushed a commit that referenced this pull request Dec 9, 2023
@mergify @luohaha
[BugFix] fix delete flag lost in persistent index minor compact (back…
a747010 
…port #36731) (#36736)

Signed-off-by: Yixin Luo <18810541851@163.com>
Co-authored-by: Yixin Luo <18810541851@163.com>
luohaha added a commit to luohaha/starrocks that referenced this pull request Dec 11, 2023
@mergify @luohaha
[BugFix] fix delete flag lost in persistent index minor compact (back…
ecec02f 
…port StarRocks#36731) (StarRocks#36736)

Signed-off-by: Yixin Luo <18810541851@163.com>
Co-authored-by: Yixin Luo <18810541851@163.com>
dingxin-tech pushed a commit to dingxin-tech/starrocks-odps that referenced this pull request Dec 12, 2023
@luohaha @dingxin-tech
[BugFix] fix delete flag lost in persistent index minor compact (Star…
be11fab 
…Rocks#36731)

Signed-off-by: luohaha <18810541851@163.com>
Signed-off-by: 鼎昕 <zhangdingxin.zdx@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decster decster decster approved these changes

@sevev sevev sevev approved these changes

@chaoyli chaoyli chaoyli left review comments

Assignees

@luohaha luohaha

Labels
backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@luohaha @decster @sevev @chaoyli @wanpengfei-git