Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix insert into files plan #36541

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

wyb
Copy link
Contributor

@wyb wyb commented Dec 6, 2023

Why I'm doing:

mysql> insert into files ("path" = "hdfs://127.0.0.1:9000/files/", "format"="parquet", "compression" = "uncompressed") select 1 as k1;
ERROR 1064 (HY000): Getting analyzing error. Detail message: Unknown database 'table_function_db'.

target table in insert into files statement is TableFunctionTable and not need to begin transaction

What I'm doing:

fix this

Fixes #36225

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

target table in insert into files statement is TableFunctionTable and not need to begin transaction

Signed-off-by: wyb <wybb86@gmail.com>
@mergify mergify bot assigned wyb Dec 6, 2023
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link

github-actions bot commented Dec 6, 2023

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Dec 6, 2023

[FE Incremental Coverage Report]

pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/StatementPlanner.java 4 4 100.00% []

@imay imay merged commit ca7dcbf into StarRocks:main Dec 7, 2023
50 checks passed
dingxin-tech pushed a commit to dingxin-tech/starrocks-odps that referenced this pull request Dec 12, 2023
```
mysql> insert into files ("path" = "hdfs://127.0.0.1:9000/files/", "format"="parquet", "compression" = "uncompressed") select 1 as k1;
ERROR 1064 (HY000): Getting analyzing error. Detail message: Unknown database 'table_function_db'.
```

target table in insert into files statement is TableFunctionTable and not need to begin transaction

Signed-off-by: wyb <wybb86@gmail.com>
Signed-off-by: 鼎昕 <zhangdingxin.zdx@alibaba-inc.com>
wyb added a commit to wyb/starrocks that referenced this pull request Dec 22, 2023
```
mysql> insert into files ("path" = "hdfs://127.0.0.1:9000/files/", "format"="parquet", "compression" = "uncompressed") select 1 as k1;
ERROR 1064 (HY000): Getting analyzing error. Detail message: Unknown database 'table_function_db'.
```

target table in insert into files statement is TableFunctionTable and not need to begin transaction

Signed-off-by: wyb <wybb86@gmail.com>
@github-actions github-actions bot added the 3.2 label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants