Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] upgrade lake persistent index version #35894

Merged
merged 1 commit into from
Nov 28, 2023
Merged

[BugFix] upgrade lake persistent index version #35894

merged 1 commit into from
Nov 28, 2023

Conversation

luohaha
Copy link
Contributor

@luohaha luohaha commented Nov 28, 2023 •
edited
Loading

Why I'm doing:
To support persistent index compression, we already upgrade persistent index's format version to 4. But when load from lake tablet, miss check this version.

What I'm doing:
check format version 4 when load from lake tablet.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@luohaha
[BugFix] upgrade lake persistent index version
784d49d 
Signed-off-by: luohaha <18810541851@163.com>
@github-actions github-actions bot added the 3.2 label Nov 28, 2023
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

❌ fail : 3 / 5 (60.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/storage/lake/lake_local_persistent_index.cpp 3 5 60.00% [78, 79]

@wyb wyb merged commit 17babdf into StarRocks:main Nov 28, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 28, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 28, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 28, 2023
@luohaha @mergify
[BugFix] upgrade lake persistent index version (#35894)
a68d1c9 
Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit 17babdf)
@mergify mergify bot mentioned this pull request Nov 28, 2023
Merged
wanpengfei-git pushed a commit that referenced this pull request Nov 28, 2023
@luohaha @wanpengfei-git
[BugFix] upgrade lake persistent index version (#35894)
3d5b712 
Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit 17babdf)
@luohaha
Copy link
Contributor Author

luohaha commented Dec 18, 2023

https://github.com/Mergifyio backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 18, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify mergify bot mentioned this pull request Dec 18, 2023
Merged
17 tasks
mergify bot pushed a commit that referenced this pull request Dec 18, 2023
@luohaha @mergify
[BugFix] upgrade lake persistent index version (#35894)
8f4858e 
Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit 17babdf)

# Conflicts:
#	be/src/storage/lake/lake_local_persistent_index.cpp
wanpengfei-git pushed a commit that referenced this pull request Dec 19, 2023
@mergify @luohaha
[BugFix] upgrade lake persistent index version (backport #35894) (#37283
a13fe44 
)

Signed-off-by: Yixin Luo <18810541851@163.com>
Co-authored-by: Yixin Luo <18810541851@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decster decster decster approved these changes

@wyb wyb wyb approved these changes

Assignees

@luohaha luohaha

Labels
3.1 3.2 backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luohaha @decster @wyb @wanpengfei-git