Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] show_fe_verion adds friendly prompts #35867

Merged
merged 3 commits into from
Nov 28, 2023
Merged

[Enhancement] show_fe_verion adds friendly prompts #35867

merged 3 commits into from
Nov 28, 2023

Conversation

Astralidea
Copy link
Contributor

Why I'm doing:
There is no prompt message when the user uses jdk8 to execute this script.
What I'm doing:
Add prompt information to allow users to reduce the time spent checking problems.
Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: Astralidea <astralidea@163.com>
@Astralidea Astralidea enabled auto-merge (squash) November 27, 2023 11:42
gengjun-git
gengjun-git previously approved these changes Nov 27, 2023
bin/show_fe_version.sh Outdated Show resolved Hide resolved
Signed-off-by: Astralidea <astralidea@163.com>
bin/show_fe_version.sh Outdated Show resolved Hide resolved
Signed-off-by: Astralidea <astralidea@163.com>
Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@Astralidea Astralidea merged commit 3f25332 into StarRocks:main Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants