[Enhancement]optimize subfield expr evaluate when copy is no need #35585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zombee0
force-pushed
the
optimize_subfiled
branch
4 times, most recently
from
e8533e4 to
34f5ae1
Compare
Signed-off-by: zombee0 <ewang2027@gmail.com>
zombee0
force-pushed
the
optimize_subfiled
branch
from
34f5ae1 to
edb572e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
[FE Incremental Coverage Report]✅ pass : 52 / 56 (92.86%) file detail
|
[BE Incremental Coverage Report]❌ fail : 5 / 7 (71.43%) file detail
|
Seaven
reviewed
Nov 27, 2023
| for (int i = 0; i < projectMapValues.size(); i++) { | ||
| ScalarOperator value = projectMapValues.get(i); | ||
| // only deal with subfield expr of slotRef | ||
| if (value instanceof SubfieldOperator && value.getChild(0) instanceof ColumnRefOperator) { |
There was a problem hiding this comment.
I think don't need the condition?
There was a problem hiding this comment.
this is used to simplify the case
Smith-Cruise
approved these changes
Nov 28, 2023
Seaven
approved these changes
Nov 29, 2023
Youngwb
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
subfield expr of struct evaluate cost a lot because of memory copy.
What I'm doing:
Don't copy when copy is no need for subfiled expr.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: