Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix partition prune for str2date materialized views with in predicate #35001

Merged

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Nov 14, 2023

Why I'm doing:

Query with partitioned mv which is created by str2date will return wrong result when it meets in-predicates.

This is because the mv has a string date type partition column and a date type partition key which may be not handled in partition pruner.

36641016-809e-4998-9185-64fa54d9e3f3

What I'm doing:

  • Try to convert query expr into date type from strong type when it is not in inPredicate optimization.
  • Not use inPredicate optimization when the partition filter does not contain lower-bound and upper-bound.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 25 / 28 (89.29%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/planner/PartitionColumnFilter.java 9 12 75.00% [181, 186, 212]
🔵 com/starrocks/planner/RangePartitionPruner.java 13 13 100.00% []
🔵 com/starrocks/connector/PartitionUtil.java 3 3 100.00% []

@LiShuMing LiShuMing merged commit 77fb6ae into StarRocks:main Nov 15, 2023
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 15, 2023
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Nov 15, 2023
Copy link
Contributor

mergify bot commented Nov 15, 2023

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Nov 15, 2023

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 15, 2023
…predicate (#35001)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
(cherry picked from commit 77fb6ae)
mergify bot pushed a commit that referenced this pull request Nov 15, 2023
…predicate (#35001)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
(cherry picked from commit 77fb6ae)
LiShuMing added a commit to LiShuMing/starrocks that referenced this pull request Nov 16, 2023
…predicate (StarRocks#35001)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
LiShuMing added a commit to LiShuMing/starrocks that referenced this pull request Nov 16, 2023
…predicate (StarRocks#35001)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
ABingHuang pushed a commit that referenced this pull request Nov 16, 2023
…ws with in predicate (#35001) (#35148)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
ABingHuang pushed a commit that referenced this pull request Nov 16, 2023
…ws with in predicate (#35001) (#35145)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants