Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] use database should check privilege of pipe #34999

Merged
merged 4 commits into from
Nov 15, 2023
Merged

[BugFix] use database should check privilege of pipe #34999

merged 4 commits into from
Nov 15, 2023

Conversation

murphyatwork
Copy link
Contributor

@murphyatwork murphyatwork commented Nov 14, 2023 •
edited
Loading

Why I'm doing:

What I'm doing:

  • User has any privilege on database should be able to use database, including pipe

Fixes #34294

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@murphyatwork
pipe should implicitly grant use database privilege
f995e0f 
Signed-off-by: Murphy <mofei@starrocks.com>
@murphyatwork
test
b3eac0b 
Signed-off-by: Murphy <mofei@starrocks.com>
@murphyatwork murphyatwork requested a review from a team as a code owner November 14, 2023 13:19
@github-actions github-actions bot added the 3.2 label Nov 14, 2023
@murphyatwork
fix
71e72d4 
Signed-off-by: Murphy <mofei@starrocks.com>
satanson
satanson previously approved these changes Nov 15, 2023
View reviewed changes
Seaven
Seaven previously approved these changes Nov 15, 2023
View reviewed changes
@murphyatwork
fix
d77c288 
Signed-off-by: Murphy <mofei@starrocks.com>
@murphyatwork murphyatwork dismissed stale reviews from Seaven and satanson via d77c288 November 15, 2023 03:44
@murphyatwork murphyatwork enabled auto-merge (squash) November 15, 2023 03:45
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 18 / 19 (94.74%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/analyzer/Authorizer.java 18 19 94.74% [307]

@murphyatwork murphyatwork enabled auto-merge (squash) November 15, 2023 06:28
@murphyatwork murphyatwork merged commit f89f616 into StarRocks:main Nov 15, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 15, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 15, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 15, 2023
@murphyatwork @mergify
[BugFix] use database should check privilege of pipe (#34999)
eff6aa3 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit f89f616)
@mergify mergify bot mentioned this pull request Nov 15, 2023
Merged
wanpengfei-git pushed a commit that referenced this pull request Nov 15, 2023
@murphyatwork @wanpengfei-git
[BugFix] use database should check privilege of pipe (#34999)
897f548 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit f89f616)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@satanson satanson satanson approved these changes

@kangkaisen kangkaisen kangkaisen approved these changes

@HangyuanLiu HangyuanLiu HangyuanLiu approved these changes

@nshangyiming nshangyiming nshangyiming approved these changes

@Seaven Seaven Seaven left review comments

Assignees

@murphyatwork murphyatwork

Labels
backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pipe load] user hava pipe'permission,but can't use database
7 participants
@murphyatwork @satanson @Seaven @kangkaisen @HangyuanLiu @nshangyiming @wanpengfei-git